From: Andi Shyti <andi.shyti@linux.intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Simona Vetter <simona.vetter@ffwll.ch>,
Andi Shyti <andi.shyti@linux.intel.com>,
Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
Krzysztof Niemiec <krzysztof.niemiec@intel.com>
Subject: Re: [PATCH 3/6] drm: Remove drm_modeset_backoff() return code
Date: Mon, 8 Sep 2025 13:06:33 +0200 [thread overview]
Message-ID: <aL64uVL06mhJZRnj@ashyti-mobl2.lan> (raw)
In-Reply-To: <875e9a8b71dd3dfe7b865acb489755b4a205a55a.1756995162.git.krzysztof.karas@intel.com>
Hi Krzysztof,
On Mon, Sep 08, 2025 at 09:24:56AM +0000, Krzysztof Karas wrote:
> We do not care about the value returned from that function
> during initialization.
>
> Cc: Simona Vetter <simona.vetter@ffwll.ch>
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
> drivers/gpu/drm/drm_mode_config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index 25f376869b3a..69a923e1bdfe 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
> @@ -471,7 +471,7 @@ int drmm_mode_config_init(struct drm_device *dev)
> ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> &modeset_ctx);
> if (ret == -EDEADLK)
> - ret = drm_modeset_backoff(&modeset_ctx);
> + drm_modeset_backoff(&modeset_ctx);
This is a very insignificant change because whether we set ret or
we don't it doesn't change anything.
Up to Sima.
Andi
next prev parent reply other threads:[~2025-09-08 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 9:22 [PATCH 0/6] drm: Miscellaneous fixes in drm code Krzysztof Karas
2025-09-08 9:23 ` [PATCH 1/6] drm/i915/gem: Avoid accessing uninitialized context in emit_rpcs_query() Krzysztof Karas
2025-09-08 10:54 ` Andi Shyti
2025-09-08 11:02 ` Sebastian Brzezinka
2025-09-08 9:23 ` [PATCH 2/6] drm/i915: Add default case for the switch in igt_smoke_tiling() Krzysztof Karas
2025-09-08 11:03 ` Andi Shyti
2025-09-09 6:16 ` Krzysztof Karas
2025-09-08 9:24 ` [PATCH 3/6] drm: Remove drm_modeset_backoff() return code Krzysztof Karas
2025-09-08 11:06 ` Andi Shyti [this message]
2025-09-09 6:11 ` Krzysztof Karas
2025-09-08 9:25 ` [PATCH 4/6] drm: Avoid suspicious operations in drm_fb_dma_get_gem_addr() Krzysztof Karas
2025-09-08 11:25 ` Sebastian Brzezinka
2025-09-08 9:26 ` [PATCH 5/6] drm: Do not attempt to round_up() zeros in drm_suballoc_try_alloc() Krzysztof Karas
2025-09-08 9:27 ` [PATCH 6/6] drm: Avoid undefined behavior on u16 multiplication Krzysztof Karas
2025-09-08 9:44 ` Jani Nikula
2025-09-08 11:39 ` Jani Nikula
2025-09-09 6:07 ` Krzysztof Karas
2025-09-08 9:39 ` [PATCH 0/6] drm: Miscellaneous fixes in drm code Jani Nikula
2025-09-08 17:48 ` ✗ i915.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL64uVL06mhJZRnj@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
--cc=krzysztof.niemiec@intel.com \
--cc=sebastian.brzezinka@intel.com \
--cc=simona.vetter@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox