From: Zhenyu Wang <zhenyuw.linux@gmail.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: intel-gfx@lists.freedesktop.org, saurabhg.gupta@intel.com,
alex.zuo@intel.com
Subject: Re: [PATCH 0/2] drm/i915/gvt: Various mmio.c fixes
Date: Wed, 17 Sep 2025 13:39:01 +0900 [thread overview]
Message-ID: <aMo7ZY6hBl_7wQn3@dell-wzy> (raw)
In-Reply-To: <20250916174317.76521-4-jonathan.cavitt@intel.com>
On Tue, Sep 16, 2025 at 05:43:18PM +0000, Jonathan Cavitt wrote:
> Remove the 'reg >= 0' check from reg_is_mmio because it's unnecessary
> due to it always being true. Also, fix the kernel docs for
> intel_vgpu_gpa_to_mmio_offset, as they incorrectly assert it returns
> 'Zero on success, negative error code if failed', when in reality it
> returns 'the MMIO offset of the given GPA'.
>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
>
> Jonathan Cavitt (2):
> drm/i915/gvt: Remove unnecessary check in reg_is_mmio
> drm/i915/gvt: Fix intel_vgpu_gpa_to_mmio_offset kernel docs
>
> drivers/gpu/drm/i915/gvt/mmio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Looks fine.
Reviewed-by: Zhenyu Wang <zhenyuw.linux@gmail.com>
next prev parent reply other threads:[~2025-09-17 4:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 17:43 [PATCH 0/2] drm/i915/gvt: Various mmio.c fixes Jonathan Cavitt
2025-09-16 17:43 ` [PATCH 1/2] drm/i915/gvt: Remove unnecessary check in reg_is_mmio Jonathan Cavitt
2025-09-17 8:59 ` Andi Shyti
2025-09-16 17:43 ` [PATCH 2/2] drm/i915/gvt: Fix intel_vgpu_gpa_to_mmio_offset kernel docs Jonathan Cavitt
2025-09-17 9:00 ` Andi Shyti
2025-09-16 18:54 ` ✓ i915.CI.BAT: success for drm/i915/gvt: Various mmio.c fixes Patchwork
2025-09-16 23:30 ` ✗ i915.CI.Full: failure " Patchwork
2025-09-17 4:39 ` Zhenyu Wang [this message]
2025-09-17 16:04 ` ✓ i915.CI.BAT: success for drm/i915/gvt: Various mmio.c fixes (rev2) Patchwork
2025-09-17 19:04 ` ✓ i915.CI.Full: " Patchwork
2025-09-18 11:17 ` [PATCH 0/2] drm/i915/gvt: Various mmio.c fixes Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMo7ZY6hBl_7wQn3@dell-wzy \
--to=zhenyuw.linux@gmail.com \
--cc=alex.zuo@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=saurabhg.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).