From: Imre Deak <imre.deak@intel.com>
To: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/2] drm/i915/display: Extract separate AUX PW descriptors
Date: Thu, 2 Oct 2025 11:58:53 +0300 [thread overview]
Message-ID: <aN4-zYRmBz1xWdLK@ideak-desk> (raw)
In-Reply-To: <20251001-pica-power-before-aux-v2-1-6308df4de5a8@intel.com>
On Wed, Oct 01, 2025 at 01:04:48PM -0300, Gustavo Sousa wrote:
> In an upcoming change, we will fix an ordering issue between PICA and
> AUX power wells for Xe2_LPD and later, making sure that the driver
> acquires PICA power before AUX. As a preparation for that, let's
> extract separate descriptors for AUX power wells.
>
> Suggested-by: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Thanks, this also unifies the xe, xe2, xe3 (except for wcl) aux
definitions:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> .../gpu/drm/i915/display/intel_display_power_map.c | 26 ++++++++++++----------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power_map.c b/drivers/gpu/drm/i915/display/intel_display_power_map.c
> index 39b71fffa2cd..e89f18b7037f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power_map.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power_map.c
> @@ -1516,7 +1516,11 @@ static const struct i915_power_well_desc xelpdp_power_wells_main[] = {
> .ops = &hsw_power_well_ops,
> .irq_pipe_mask = BIT(PIPE_D),
> .has_fuses = true,
> - }, {
> + },
> +};
> +
> +static const struct i915_power_well_desc xelpdp_power_wells_aux[] = {
> + {
> .instances = &I915_PW_INSTANCES(
> I915_PW("AUX_A", &icl_pwdoms_aux_a, .xelpdp.aux_ch = AUX_CH_A),
> I915_PW("AUX_B", &icl_pwdoms_aux_b, .xelpdp.aux_ch = AUX_CH_B),
> @@ -1534,6 +1538,7 @@ static const struct i915_power_well_desc_list xelpdp_power_wells[] = {
> I915_PW_DESCRIPTORS(icl_power_wells_pw_1),
> I915_PW_DESCRIPTORS(xelpd_power_wells_dc_off),
> I915_PW_DESCRIPTORS(xelpdp_power_wells_main),
> + I915_PW_DESCRIPTORS(xelpdp_power_wells_aux),
> };
>
> I915_DECL_PW_DOMAINS(xe2lpd_pwdoms_pica_tc,
> @@ -1583,6 +1588,7 @@ static const struct i915_power_well_desc_list xe2lpd_power_wells[] = {
> I915_PW_DESCRIPTORS(icl_power_wells_pw_1),
> I915_PW_DESCRIPTORS(xe2lpd_power_wells_dcoff),
> I915_PW_DESCRIPTORS(xelpdp_power_wells_main),
> + I915_PW_DESCRIPTORS(xelpdp_power_wells_aux),
> I915_PW_DESCRIPTORS(xe2lpd_power_wells_pica),
> };
>
> @@ -1677,16 +1683,6 @@ static const struct i915_power_well_desc xe3lpd_power_wells_main[] = {
> .ops = &hsw_power_well_ops,
> .irq_pipe_mask = BIT(PIPE_D),
> .has_fuses = true,
> - }, {
> - .instances = &I915_PW_INSTANCES(
> - I915_PW("AUX_A", &icl_pwdoms_aux_a, .xelpdp.aux_ch = AUX_CH_A),
> - I915_PW("AUX_B", &icl_pwdoms_aux_b, .xelpdp.aux_ch = AUX_CH_B),
> - I915_PW("AUX_TC1", &xelpdp_pwdoms_aux_tc1, .xelpdp.aux_ch = AUX_CH_USBC1),
> - I915_PW("AUX_TC2", &xelpdp_pwdoms_aux_tc2, .xelpdp.aux_ch = AUX_CH_USBC2),
> - I915_PW("AUX_TC3", &xelpdp_pwdoms_aux_tc3, .xelpdp.aux_ch = AUX_CH_USBC3),
> - I915_PW("AUX_TC4", &xelpdp_pwdoms_aux_tc4, .xelpdp.aux_ch = AUX_CH_USBC4),
> - ),
> - .ops = &xelpdp_aux_power_well_ops,
> },
> };
>
> @@ -1714,6 +1710,7 @@ static const struct i915_power_well_desc_list xe3lpd_power_wells[] = {
> I915_PW_DESCRIPTORS(icl_power_wells_pw_1),
> I915_PW_DESCRIPTORS(xe3lpd_power_wells_dcoff),
> I915_PW_DESCRIPTORS(xe3lpd_power_wells_main),
> + I915_PW_DESCRIPTORS(xelpdp_power_wells_aux),
> I915_PW_DESCRIPTORS(xe2lpd_power_wells_pica),
> };
>
> @@ -1751,7 +1748,11 @@ static const struct i915_power_well_desc wcl_power_wells_main[] = {
> .ops = &hsw_power_well_ops,
> .irq_pipe_mask = BIT(PIPE_C),
> .has_fuses = true,
> - }, {
> + },
> +};
> +
> +static const struct i915_power_well_desc wcl_power_wells_aux[] = {
> + {
> .instances = &I915_PW_INSTANCES(
> I915_PW("AUX_A", &icl_pwdoms_aux_a, .xelpdp.aux_ch = AUX_CH_A),
> I915_PW("AUX_B", &icl_pwdoms_aux_b, .xelpdp.aux_ch = AUX_CH_B),
> @@ -1767,6 +1768,7 @@ static const struct i915_power_well_desc_list wcl_power_wells[] = {
> I915_PW_DESCRIPTORS(icl_power_wells_pw_1),
> I915_PW_DESCRIPTORS(xe3lpd_power_wells_dcoff),
> I915_PW_DESCRIPTORS(wcl_power_wells_main),
> + I915_PW_DESCRIPTORS(wcl_power_wells_aux),
> I915_PW_DESCRIPTORS(xe2lpd_power_wells_pica),
> };
>
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-10-02 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 16:04 [PATCH v2 0/2] drm/i915/display: Enable PICA power before AUX Gustavo Sousa
2025-10-01 16:04 ` [PATCH v2 1/2] drm/i915/display: Extract separate AUX PW descriptors Gustavo Sousa
2025-10-02 8:58 ` Imre Deak [this message]
2025-10-01 16:04 ` [PATCH v2 2/2] drm/i915/display: Enable PICA power before AUX Gustavo Sousa
2025-10-02 9:05 ` Imre Deak
2025-10-03 14:09 ` Gustavo Sousa
2025-10-01 17:21 ` ✓ i915.CI.BAT: success for drm/i915/display: Enable PICA power before AUX (rev2) Patchwork
2025-10-01 21:39 ` ✗ i915.CI.Full: failure " Patchwork
2025-10-02 21:22 ` Gustavo Sousa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN4-zYRmBz1xWdLK@ideak-desk \
--to=imre.deak@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox