Re: [PATCH 3/4] drm/i915/opregion: Make intel_opregion_notify_adapter() static

[Imre Deak <imre.deak@intel.com>]

On Tue, Jul 08, 2025 at 07:03:19PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> intel_opregion_notify_adapter() is no longer needed outside
> intel_opregion.c. Make it static.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_opregion.c | 4 ++--
>  drivers/gpu/drm/i915/display/intel_opregion.h | 8 --------
>  2 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c
> index 9e39ab55a099..e99616ea2ae6 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.c
> @@ -470,8 +470,8 @@ static const struct {
>  	{ PCI_D3cold,	0x04 },
>  };
>  
> -int intel_opregion_notify_adapter(struct intel_display *display,
> -				  pci_power_t state)
> +static int intel_opregion_notify_adapter(struct intel_display *display,
> +					 pci_power_t state)
>  {
>  	int i;
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h
> index 7067ffe07744..d5b60029e007 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.h
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.h
> @@ -51,8 +51,6 @@ bool intel_opregion_asle_present(struct intel_display *display);
>  void intel_opregion_asle_intr(struct intel_display *display);
>  int intel_opregion_notify_encoder(struct intel_encoder *encoder,
>  				  bool enable);
> -int intel_opregion_notify_adapter(struct intel_display *display,
> -				  pci_power_t state);
>  int intel_opregion_get_panel_type(struct intel_display *display);
>  const struct drm_edid *intel_opregion_get_edid(struct intel_connector *connector);
>  
> @@ -114,12 +112,6 @@ intel_opregion_notify_encoder(struct intel_encoder *encoder, bool enable)
>  	return 0;
>  }
>  
> -static inline int
> -intel_opregion_notify_adapter(struct intel_display *display, pci_power_t state)
> -{
> -	return 0;
> -}
> -
>  static inline int intel_opregion_get_panel_type(struct intel_display *display)
>  {
>  	return -ENODEV;
> -- 
> 2.49.0
>