Re: [PATCH v2 4/4] tracing: move tracing declarations from kernel.h to a dedicated header

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Dec 03, 2025 at 11:23:25AM -0500, Yury Norov (NVIDIA) wrote:
> Tracing is a half of the kernel.h in terms of LOCs, although it's
> a self-consistent part. It is intended for quick debugging purposes
> and isn't used by the normal tracing utilities.
> 
> Move it to a separate header. If someone needs to just throw a
> trace_printk() in their driver, they will not have to pull all
> the heavy tracing machinery.
> 
> This is a pure move, except for removing a few 'extern's.

...

>  #include <linux/build_bug.h>
>  #include <linux/sprintf.h>
>  #include <linux/static_call_types.h>
> +#include <linux/tracing.h>

>  #include <linux/instruction_pointer.h>

And kill this one? We really don't care about the mess in the kernel.h right
now, and your header will bring that anyway. Also consider killing other
inclusions that has been moved from kernel.h to tracing.h.

>  #include <linux/util_macros.h>
>  #include <linux/wordpart.h>

...

> +#ifndef _LINUX_TRACING_H
> +#define _LINUX_TRACING_H
> +
> +#include <linux/compiler_attributes.h>
> +#include <linux/instruction_pointer.h>

+ stddef.h // you use NULL

+ string.h // use of strlen()

> +#include <linux/stringify.h>

-- 
With Best Regards,
Andy Shevchenko