From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>,
Direct Rendering Infrastructure - Development
<dri-devel@lists.freedesktop.org>,
Norbert Lange <nolange79@gmail.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: Mark dependency on CONFIG_X86_PAT
Date: Tue, 16 Dec 2025 23:38:53 +0200 [thread overview]
Message-ID: <aUHRbTRd0NQ4GbXc@intel.com> (raw)
In-Reply-To: <20251216113512.153447-1-joonas.lahtinen@linux.intel.com>
On Tue, Dec 16, 2025 at 01:35:12PM +0200, Joonas Lahtinen wrote:
> Building the driver without CONFIG_X86_PAT would yield in reduced
> platform/uAPI support and is not currently planned to be supported.
>
> Add a dependency in Kconfig to avoid issues with such build until
> somebody steps up to fix and validate such builds.
The driver works just fine w/o PAT on older GPUs at least. Otherwise
it wouldn't work at all on any P3 class CPU as the kernel completely
disables PAT support on those even if the kernel is built with
X86_PAT=y. You can also disable PAT on the command line with "nopat".
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15410
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Reported-by: Norbert Lange <nolange79@gmail.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Tvrtko Ursulin <tursulin@ursulin.net>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 5e939004b6463..a19a233239056 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -2,7 +2,7 @@
> config DRM_I915
> tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
> depends on DRM
> - depends on X86 && PCI
> + depends on X86 && X86_PAT && PCI
> depends on !PREEMPT_RT
> select INTEL_GTT if X86
> select INTERVAL_TREE
> --
> 2.52.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2025-12-16 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 11:35 [PATCH] drm/i915: Mark dependency on CONFIG_X86_PAT Joonas Lahtinen
2025-12-16 11:53 ` Jani Nikula
2025-12-16 12:25 ` ✓ i915.CI.BAT: success for " Patchwork
2025-12-16 14:58 ` ✗ i915.CI.Full: failure " Patchwork
2025-12-16 21:38 ` Ville Syrjälä [this message]
2025-12-17 7:52 ` [PATCH] " Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUHRbTRd0NQ4GbXc@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=nolange79@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox