From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: mika.kahola@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit
Date: Mon, 30 Jan 2017 15:16:27 +0100 [thread overview]
Message-ID: <aa2a1926-4b40-f5cf-8cf1-72b1e4de2aa0@linux.intel.com> (raw)
In-Reply-To: <1485782524.9014.144.camel@intel.com>
Op 30-01-17 om 14:22 schreef Mika Kahola:
> On Mon, 2017-01-30 at 13:43 +0100, Maarten Lankhorst wrote:
>> Op 30-01-17 om 12:37 schreef Mika Kahola:
>>> Validate atomic commit correctness before actual commit.
>>>
>>> For: VIZ-6956
>>>
>>> v2: Add flag to toggle TEST_ONLY for atomic commit.
>>> Remove DRM_MODE_PAGE_FLIP_EVENT flag, if enabled, before trying
>>> atomic
>>> commit with TEST_ONLY flag (Maarten)
>>>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>
>>> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
>>> <snip>
>> Hey,
>>
>> Way too complicated, I thought of something like this instead too run
>> a whole test with TEST_ONLY.
> Ok, let's go with this approach.
>
> To follow JIRA description for this test I was thinking to add yet
> another subtest for each kms_* that tests first with TEST_ONLY flag and
> if that fails with -EINVAL then test with the real deal.
Yeah, this is mostly meant for debugging in some existing tests. To validate
TEST_ONLY we could add a kms_atomic_test_only test, which can also be used to
see if a test with TEST_ONLY is not accidentally being committed by reading
plane/connector/crtc properties and compare before against after, which is also a JIRA.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-01-30 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 11:37 [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit Mika Kahola
2017-01-30 12:43 ` Maarten Lankhorst
2017-01-30 13:22 ` Mika Kahola
2017-01-30 14:16 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa2a1926-4b40-f5cf-8cf1-72b1e4de2aa0@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox