From: "Dhanavanthri, Swathi" <swathi.dhanavanthri@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
Date: Sat, 12 Sep 2020 04:00:49 +0000 [thread overview]
Message-ID: <ab65ffc77785459588e22ea0f76d6e28@intel.com> (raw)
In-Reply-To: <20200912011026.GA265632@intel.com>
It is in the if statement: if (IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
-----Original Message-----
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Sent: Friday, September 11, 2020 6:10 PM
To: Dhanavanthri, Swathi <swathi.dhanavanthri@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
On Fri, Sep 11, 2020 at 03:11:58PM -0700, Swathi Dhanavanthri wrote:
> This workaround applies to all TGL and RKL steppings.
>
> Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 39817c5a7058..6c580d0d9ea8 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1729,10 +1729,11 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
> GEN6_RC_SLEEP_PSMI_CONTROL,
> GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
> GEN8_RC_SEMA_IDLE_MSG_DISABLE);
> - }
>
> - if (IS_TGL_U(i915) || IS_TGL_Y(i915)) {
please notice this function is called for other gens.
In case you need to extend this to other platforms, please add them to the if instead of removing the if.
> - /* Wa_1606700617:tgl */
> + /*
> + * Wa_1606700617:tgl
> + * Wa_22010271021:tgl,rkl
> + */
> wa_masked_en(wal,
> GEN9_CS_DEBUG_MODE1,
> FF_DOP_CLOCK_GATE_DISABLE);
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-12 4:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 22:11 [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent Swathi Dhanavanthri
2020-09-11 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-12 0:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-09-12 1:10 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2020-09-12 4:00 ` Dhanavanthri, Swathi [this message]
2020-09-14 20:05 ` Vivi, Rodrigo
2020-09-14 23:56 ` Vivi, Rodrigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab65ffc77785459588e22ea0f76d6e28@intel.com \
--to=swathi.dhanavanthri@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox