Re: [Intel-gfx] [PATCH] drm/i915/display: Add debug print for scaler filter

["Shankar, Uma" <uma.shankar@intel.com>]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Swati
> Sharma
> Sent: Wednesday, July 6, 2022 3:53 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH] drm/i915/display: Add debug print for scaler filter
> 
> Add debug print statement to print scaler filter property value. Since property can be
> set as either default or integer scaler; its good if we can get debug print for the same
> in dmesg log.

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 9 +++++----
> drivers/gpu/drm/i915/display/intel_display_debugfs.c | 5 +++--
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> index 4ca6e9493ff2..e9212f69c360 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> @@ -134,8 +134,8 @@ static void intel_dump_plane_state(const struct
> intel_plane_state *plane_state)
>  		    plane->base.base.id, plane->base.name,
>  		    fb->base.id, fb->width, fb->height, &fb->format->format,
>  		    fb->modifier, str_yes_no(plane_state->uapi.visible));
> -	drm_dbg_kms(&i915->drm, "\trotation: 0x%x, scaler: %d\n",
> -		    plane_state->hw.rotation, plane_state->scaler_id);
> +	drm_dbg_kms(&i915->drm, "\trotation: 0x%x, scaler: %d, scaling_filter:
> %d\n",
> +		    plane_state->hw.rotation, plane_state->scaler_id,
> +plane_state->hw.scaling_filter);
>  	if (plane_state->uapi.visible)
>  		drm_dbg_kms(&i915->drm,
>  			    "\tsrc: " DRM_RECT_FP_FMT " dst: " DRM_RECT_FMT
> "\n", @@ -262,10 +262,11 @@ void intel_crtc_state_dump(const struct
> intel_crtc_state *pipe_config,
> 
>  	if (DISPLAY_VER(i915) >= 9)
>  		drm_dbg_kms(&i915->drm,
> -			    "num_scalers: %d, scaler_users: 0x%x, scaler_id: %d\n",
> +			    "num_scalers: %d, scaler_users: 0x%x, scaler_id: %d,
> +scaling_filter: %d\n",
>  			    crtc->num_scalers,
>  			    pipe_config->scaler_state.scaler_users,
> -			    pipe_config->scaler_state.scaler_id);
> +			    pipe_config->scaler_state.scaler_id,
> +			    pipe_config->hw.scaling_filter);
> 
>  	if (HAS_GMCH(i915))
>  		drm_dbg_kms(&i915->drm,
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 6c3954479047..225b6bfc783c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -722,10 +722,11 @@ static void intel_scaler_info(struct seq_file *m, struct
> intel_crtc *crtc)
> 
>  	/* Not all platformas have a scaler */
>  	if (num_scalers) {
> -		seq_printf(m, "\tnum_scalers=%d, scaler_users=%x scaler_id=%d",
> +		seq_printf(m, "\tnum_scalers=%d, scaler_users=%x scaler_id=%d
> +scaling_filter=%d",
>  			   num_scalers,
>  			   crtc_state->scaler_state.scaler_users,
> -			   crtc_state->scaler_state.scaler_id);
> +			   crtc_state->scaler_state.scaler_id,
> +			   crtc_state->hw.scaling_filter);
> 
>  		for (i = 0; i < num_scalers; i++) {
>  			const struct intel_scaler *sc =
> --
> 2.25.1