Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual (rev4)

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

On 10/27/2022 6:30 PM, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual (rev4)
> URL   : https://patchwork.freedesktop.org/series/108972/
> State : warning
> 
> == Summary ==
> 
> Error: dim checkpatch failed
> d83d4490c920 drm/i915: Encapsulate lmem rpm stuff in intel_runtime_pm
> -:69: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
> #69: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1105:
> +		list_add(&obj->userfault_link, &to_i915(obj->base.dev)->runtime_pm.lmem_userfault_list);
Code if block is more readable in single line.
> 
> total: 0 errors, 1 warnings, 0 checks, 147 lines checked
> 721d116886f7 drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual
> -:44: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
> #44: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:564:
> +	GEM_BUG_ON(!obj->userfault_count);
> 
> -:155: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
Above is a false alarm, there is already an existing comment about the 
lock usages.
Br,
Anshuman Gupta.
> #155: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:67:
> +	spinlock_t lmem_userfault_lock;
> 
> total: 0 errors, 1 warnings, 1 checks, 109 lines checked
> 
>