Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Dave Airlie" <airlied@gmail.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Yassine Mounir" <sosohero200@gmail.com>,
	g@web.codeaurora.org, gregkh@linuxfoundation.org,
	intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com,
	security@kernel.org
Subject: Re: [PATCH v2] [PATCH v2] drm/i915/gem: Fix UAF race in eb_relocate_vma
Date: Thu, 9 Apr 2026 01:05:02 -0700	[thread overview]
Message-ID: <adddrlQojq8fo2iE@gsse-cloud1.jf.intel.com> (raw)
In-Reply-To: <CAHk-=wjcSt1gGnQZoyNvodky_6WEDxC=1+gQHywiOvOjw1+GUA@mail.gmail.com>

On Tue, Apr 07, 2026 at 09:46:42AM -0700, Linus Torvalds wrote:
> On Tue, 7 Apr 2026 at 09:38, Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com> wrote:
> >
> > The big question is, what stance to take on a value of AI generated low
> > quality reproducer code which was accompanied by wall of AI slop which

The reproducers from what I've seen are complete slot.

> > caused hours of time get wasted on debunking the hallucinations?
> 
> I don't th8nk there are any good rules.
> 
> Some of the AI reports we get are great, with no slop in sight and
> finding really subtle and real bugs.
> 
> And others are very much not.

+1?

I dealt with some complete AI slop today reporting a hallucination.
It was a subtle reference-counting issue that, if well documented,
probably shouldn’t have been flagged. IMO, it’s an opportunity to clean
up the code or at least document why it works. Yes, annoying, even more
so if less actively maintained status—but in general it flags hand-wavy,
questionable code that needs an explanation.

Conversely, today on fresh code, Sashiko immediately flagged very
subtle, likely nearly impossible-to-hit issues, which I appreciated, and
closed.

> 
> In general, I don't think that's all that different from bug reports
> from actual humans ;^/

So yea, problably worth a look at reports unless want to orphan code.

Matt

> 
> So I'd suggest just fixing the bugs that are noticed, and giving
> credit appropriate to how good the report was.
> 
>            Linus

  parent reply	other threads:[~2026-04-09  8:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 15:17 [PATCH v2] [PATCH v2] drm/i915/gem: Fix UAF race in eb_relocate_vma Yassine Mounir
2026-03-25  8:01 ` Joonas Lahtinen
2026-03-25  8:20   ` Yassine Mounir
2026-03-25 14:07     ` Joonas Lahtinen
2026-03-25 15:43       ` Yassine Mounir
2026-03-25 15:46       ` Rodrigo Vivi
2026-03-25 17:30         ` Yassine Mounir
2026-03-25 17:30           ` Yassine Mounir
2026-03-25 22:14             ` Rodrigo Vivi
2026-03-25 22:37               ` Yassine Mounir
2026-03-26  6:54                 ` AI slop security report against i915 (Was: Re: [PATCH v2] drm/i915/gem: Fix UAF race in eb_relocate_vma) Joonas Lahtinen
2026-03-26  8:45                   ` Greg KH
2026-03-25 15:34 ` ✗ LGCI.VerificationFailed: failure for drm/i915/gem: Fix UAF race in eb_relocate_vma Patchwork
2026-03-26 12:32 ` [PATCH v2] [PATCH v2] " Ville Syrjälä
2026-03-26 15:19   ` Linus Torvalds
2026-04-03 22:12   ` Linus Torvalds
2026-04-03 22:35     ` Yassine Mounir
2026-04-03 22:38     ` Yassine Mounir
2026-04-07 16:38     ` Joonas Lahtinen
2026-04-07 16:46       ` Linus Torvalds
2026-04-08 11:15         ` Joonas Lahtinen
2026-04-08 15:38           ` Linus Torvalds
2026-04-08 16:24             ` Joonas Lahtinen
2026-04-09 15:45               ` Linus Torvalds
2026-04-13  4:39                 ` Joonas Lahtinen
2026-04-09  8:05         ` Matthew Brost [this message]
2026-04-09 15:50           ` Linus Torvalds
2026-04-07 16:58       ` Simona Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adddrlQojq8fo2iE@gsse-cloud1.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=airlied@gmail.com \
    --cc=g@web.codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=security@kernel.org \
    --cc=sosohero200@gmail.com \
    --cc=torvalds@linuxfoundation.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox