Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/selftests: Fix live_workarounds to actually do resets
Date: Fri, 30 Nov 2018 12:17:13 +0000	[thread overview]
Message-ID: <ae0c0ef8-18dd-b451-d5a8-7099bc062573@linux.intel.com> (raw)
In-Reply-To: <154357162410.20153.12974525448393627936@skylake-alporthouse-com>


On 30/11/2018 09:53, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-11-30 08:02:54)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> The test was missing some magic ingredients to actually trigger the
>> resets.
>>
>> In case of the full reset we need the I915_RESET_HANDOFF flag set, and in
>> case of engine reset we need a busy request.
>>
>> Thanks to Chris for helping with reset magic.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Thanks for fixing up my fail,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, happy with v2 as well? (adds rpm over reset)

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-11-30 12:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30  8:02 [PATCH 1/2] drm/i915/selftests: Extract spinner code Tvrtko Ursulin
2018-11-30  8:02 ` [PATCH 2/2] drm/i915/selftests: Fix live_workarounds to actually do resets Tvrtko Ursulin
2018-11-30  9:52   ` [PATCH v2 " Tvrtko Ursulin
2018-11-30  9:53   ` [PATCH " Chris Wilson
2018-11-30 12:17     ` Tvrtko Ursulin [this message]
2018-11-30 12:55       ` Chris Wilson
2018-11-30  8:10 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Extract spinner code Patchwork
2018-11-30  8:10 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-30  8:32 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-30  9:52 ` [PATCH 1/2] " Chris Wilson
2018-11-30 11:08 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2) Patchwork
2018-11-30 11:09 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-30 11:24 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-30 15:10   ` Tvrtko Ursulin
2018-12-01  3:53 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae0c0ef8-18dd-b451-d5a8-7099bc062573@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox