From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 4/7] drm/i915/gem/ttm: Place new BOs in the requested region
Date: Wed, 4 Aug 2021 08:52:44 +0200 [thread overview]
Message-ID: <aeda5ce6-ee21-bf9e-9e37-6223f072e51d@linux.intel.com> (raw)
In-Reply-To: <7c9c608f-a00a-8890-d4fb-c4fe755e2073@linux.intel.com>
On 8/4/21 8:49 AM, Thomas Hellström wrote:
> Hi, Jason,
>
> On 7/16/21 12:38 AM, Jason Ekstrand wrote:
>> __i915_gem_ttm_object_init() was ignoring the placement requests coming
>> from the client and always placing all BOs in SMEM upon creation.
>> Instead, compute the requested placement set from the object and pass
>> that into ttm_bo_init_reserved().
>
> This is done on purpose. When objects are initially created in SMEM,
> they are created in "Limbo", meaning they have no pages and costly
> allocation and clearing is deferred to first get_pages().
>
> So we shouldn't be doing this.
Ah, I see Matthew already responded on this. Sorry for the noise.
/Thomas
next prev parent reply other threads:[~2021-08-04 6:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 22:38 [Intel-gfx] [PATCH 0/7] drm/i915: Migrate memory to SMEM when imported cross-device Jason Ekstrand
2021-07-15 22:38 ` [Intel-gfx] [PATCH 1/7] drm/i915/gem: Check object_can_migrate from object_migrate Jason Ekstrand
2021-07-15 22:38 ` [Intel-gfx] [PATCH 2/7] drm/i915/gem: Refactor placement setup for i915_gem_object_create* Jason Ekstrand
2021-07-16 11:12 ` Matthew Auld
2021-07-16 13:52 ` Jason Ekstrand
2021-07-15 22:38 ` [Intel-gfx] [PATCH 3/7] drm/i915/gem: Unify user object creation Jason Ekstrand
2021-07-16 11:20 ` Matthew Auld
2021-07-16 14:02 ` Jason Ekstrand
2021-07-20 9:34 ` Matthew Auld
2021-07-20 22:04 ` Jason Ekstrand
2021-07-21 8:24 ` Matthew Auld
2021-07-21 15:47 ` Jason Ekstrand
2021-07-21 16:29 ` Matthew Auld
2021-07-15 22:38 ` [Intel-gfx] [PATCH 4/7] drm/i915/gem/ttm: Place new BOs in the requested region Jason Ekstrand
2021-07-16 13:17 ` Matthew Auld
2021-07-16 13:46 ` Jason Ekstrand
2021-08-04 6:49 ` Thomas Hellström
2021-08-04 6:52 ` Thomas Hellström [this message]
2021-07-15 22:38 ` [Intel-gfx] [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj Jason Ekstrand
2021-07-16 13:54 ` Matthew Auld
2021-07-16 14:10 ` Jason Ekstrand
2021-07-16 15:52 ` Matthew Auld
2021-07-16 16:00 ` Matthew Auld
2021-07-16 17:38 ` Jason Ekstrand
2021-07-16 18:44 ` Matthew Auld
2021-07-16 19:49 ` Jason Ekstrand
2021-07-19 13:34 ` Matthew Auld
2021-07-21 20:11 ` Jason Ekstrand
2021-07-21 20:32 ` Daniel Vetter
2021-07-22 9:49 ` Matthew Auld
2021-07-22 9:59 ` Matthew Auld
2021-08-04 8:00 ` Thomas Hellström
2021-08-04 14:35 ` Daniel Vetter
2021-07-15 22:38 ` [Intel-gfx] [PATCH 6/7] drm/i915/gem: Correct the locking and pin pattern for dma-buf (v6) Jason Ekstrand
2021-07-15 22:39 ` [Intel-gfx] [PATCH 7/7] drm/i915/gem: Migrate to system at dma-buf attach time (v6) Jason Ekstrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeda5ce6-ee21-bf9e-9e37-6223f072e51d@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox