From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix broadwell EU computation
Date: Mon, 12 Nov 2018 15:57:05 +0000 [thread overview]
Message-ID: <aedbe052-368f-e99f-ce42-7155e33afd18@linux.intel.com> (raw)
In-Reply-To: <20181112123931.2815-1-lionel.g.landwerlin@intel.com>
On 12/11/2018 12:39, Lionel Landwerlin wrote:
> subslice_mask is an array indexed by slice, not subslice.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> ---
> drivers/gpu/drm/i915/intel_device_info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 89ed3a84a4fa..ceecb5bd5226 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
> u8 eu_disabled_mask;
> u32 n_disabled;
>
> - if (!(sseu->subslice_mask[ss] & BIT(ss)))
> + if (!(sseu->subslice_mask[s] & BIT(ss)))
> /* skip disabled subslice */
> continue;
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-12 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 12:39 [PATCH] drm/i915: fix broadwell EU computation Lionel Landwerlin
2018-11-12 13:14 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-12 14:58 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-12 15:44 ` [PATCH] " Chris Wilson
2018-11-12 15:57 ` Tvrtko Ursulin [this message]
2018-11-12 17:42 ` Lionel Landwerlin
-- strict thread matches above, loose matches on Subject: below --
2019-08-28 21:02 Rodrigo Vivi
2019-08-28 21:22 ` Lionel Landwerlin
2019-08-29 21:02 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aedbe052-368f-e99f-ce42-7155e33afd18@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox