Re: [PATCH] drm/i915/display: enable ccs modifiers on dg2

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Apr 23, 2026 at 12:15:14PM +0100, Tvrtko Ursulin wrote:
> 
> On 23/04/2026 11:28, Jani Nikula wrote:
> > On Thu, 23 Apr 2026, Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> wrote:
> >> Since Xe driver aux ccs enablement dg2 ccs modifiers have been
> >> disabled on both Xe and i915 drivers. Here allow dg2 to use
> >> ccs again for framebuffers.
> >>
> >> Fixes: 6a99e91 ("drm/i915/display: Detect AuxCCS support via display parent interface")
> >> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> >> ---
> >>   drivers/gpu/drm/i915/i915_driver.c | 5 ++++-
> >>   1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> >> index d31819758f3d..7a73461d398a 100644
> >> --- a/drivers/gpu/drm/i915/i915_driver.c
> >> +++ b/drivers/gpu/drm/i915/i915_driver.c
> >> @@ -54,9 +54,11 @@
> >>   #include "display/intel_bw.h"
> >>   #include "display/intel_cdclk.h"
> >>   #include "display/intel_crtc.h"
> >> +#include "display/intel_display_core.h"
> >>   #include "display/intel_display_device.h"
> >>   #include "display/intel_display_driver.h"
> >>   #include "display/intel_display_power.h"
> >> +#include "display/intel_display_types.h"
> >>   #include "display/intel_dmc.h"
> >>   #include "display/intel_dp.h"
> >>   #include "display/intel_dpt.h"
> >> @@ -749,8 +751,9 @@ static void fence_priority_display(struct dma_fence *fence)
> >>   static bool has_auxccs(struct drm_device *drm)
> >>   {
> >>   	struct drm_i915_private *i915 = to_i915(drm);
> >> +	struct intel_display *display = i915->display;
> >>   
> >> -	return IS_GRAPHICS_VER(i915, 9, 12) ||
> >> +	return IS_DISPLAY_VER(display, 9, 12) ||
> > 
> > Sorry, can't do this in i915 core.
> 
> Was DG2 never Gen12? I totally forgot.. my bad.. Adding IS_DG2 to the 
> checks below should work, no?

I think just exclude HAS_FLAT_CCS.

> 
> Regards,
> 
> Tvrtko
> 
> > 
> > BR,
> > Jani.
> > 
> >>   	       IS_ALDERLAKE_P(i915) ||
> >>   	       IS_METEORLAKE(i915);
> >>   }
> > 

-- 
Ville Syrjälä
Intel