Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Use intel_bo_to_drm_bo instead of obj->base
Date: Mon, 6 Nov 2023 06:34:17 +0000	[thread overview]
Message-ID: <afbfe8125487a7c579d665aba462d63aded83c7a.camel@intel.com> (raw)
In-Reply-To: <87sf5o2x0c.fsf@intel.com>

On Thu, 2023-11-02 at 13:52 +0200, Jani Nikula wrote:
> On Thu, 02 Nov 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> > We are preparing for Xe. Xe_bo doesn't have obj->base. Due to this
> > use intel_bo_to_drm_bo instead in intel_prepare_plane_fb.
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Thank you Jani for your review. This is now merged.

BR,

Jouni Högander
 
> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_atomic_plane.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > index 3b9a66923422..06c2455bdd78 100644
> > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > @@ -1096,7 +1096,7 @@ intel_prepare_plane_fb(struct drm_plane
> > *_plane,
> >                  * can safely continue.
> >                  */
> >                 if (new_crtc_state &&
> > intel_crtc_needs_modeset(new_crtc_state)) {
> > -                       ret = add_dma_resv_fences(old_obj-
> > >base.resv,
> > +                       ret =
> > add_dma_resv_fences(intel_bo_to_drm_bo(old_obj)->resv,
> >                                                   &new_plane_state-
> > >uapi);
> >                         if (ret < 0)
> >                                 return ret;
> 


  reply	other threads:[~2023-11-06  6:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 11:22 [Intel-gfx] [PATCH] drm/i915/display: Use intel_bo_to_drm_bo instead of obj->base Jouni Högander
2023-11-02 11:52 ` Jani Nikula
2023-11-06  6:34   ` Hogander, Jouni [this message]
2023-11-02 22:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-11-03 17:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afbfe8125487a7c579d665aba462d63aded83c7a.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox