Re: [PATCH 3/4] drm/i915/dp: Set sdp_type in AS SDP unpack

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, May 11, 2026 at 06:02:17PM +0530, Ankit Nautiyal wrote:
> Add sdp_type in AS SDP unpack. Since the field sdp_type is not compared
> in intel_compare_dp_as_sdp() it doesn't throw up any mismatch error yet.
> 
> In the subsequent change this field will be added along with other missing
> fields for comparison.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index fa3b0a1b6bc1..52ee17e9f210 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5366,6 +5366,7 @@ int intel_dp_as_sdp_unpack(struct drm_dp_as_sdp *as_sdp,
>  	if ((sdp->sdp_header.HB3 & 0x3F) != 9)
>  		return -EINVAL;
>  
> +	as_sdp->sdp_type = sdp->sdp_header.HB1;
>  	as_sdp->length = sdp->sdp_header.HB3 & DP_AS_SDP_LENGTH_MASK;
>  	as_sdp->revision = sdp->sdp_header.HB2;
>  	as_sdp->mode = sdp->db[0] & DP_AS_SDP_OPERATION_MODE_MASK;
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel