From: Raag Jadav <raag.jadav@intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Subject: Re: [PATCH v2] drm/i915/gt: Return bool values from a boolean helper
Date: Sat, 27 Jun 2026 06:58:16 +0200 [thread overview]
Message-ID: <aj9YaEM48RkX7DSo@black.igk.intel.com> (raw)
In-Reply-To: <20260626215232.861416-1-andi.shyti@linux.intel.com>
On Fri, Jun 26, 2026 at 11:52:32PM +0200, Andi Shyti wrote:
> intel_has_gpu_reset() returns logically correct values by
> returning a function pointer when GPU reset is supported and
> NULL otherwise. However, as a boolean helper, it is more
> appropriate to return explicit true or false values.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
> Link: https://lore.kernel.org/r/20260625114442.2912230-1-andi.shyti@linux.intel.com
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
next prev parent reply other threads:[~2026-06-27 4:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 21:52 [PATCH v2] drm/i915/gt: Return bool values from a boolean helper Andi Shyti
2026-06-27 4:58 ` Raag Jadav [this message]
2026-06-29 14:23 ` ✓ i915.CI.BAT: success for drm/i915/gt: Return bool values from a boolean helper (rev2) Patchwork
2026-06-29 19:37 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aj9YaEM48RkX7DSo@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=andi.shyti@kernel.org \
--cc=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=sebastian.brzezinka@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox