Re: [PATCH v3 3/8] drm/i915/selftests: Use drm_* prints in selftest helpers

[Andi Shyti <andi.shyti@kernel.org>]

Hi krzysztof,

>  	i915 = devm_drm_dev_alloc(&pdev->dev, &mock_driver,
>  				  struct drm_i915_private, drm);
>  	if (IS_ERR(i915)) {
> -		pr_err("Failed to allocate mock GEM device: err=%ld\n", PTR_ERR(i915));
> +		dev_err(&pdev->dev,
> +			"Failed to allocate mock GEM device: err=%ld\n",
> +			PTR_ERR(i915));

good choice here to use dev_err(...);

Reviewed-by: Andi Shyti <andi.shyti@linux.inte.com>

Also here you forgot to add my r-b. People normally spend time to
do reviews and it's not nice to ignore them.

Andi

>  		devres_release_group(&pdev->dev, NULL);
>  		put_device(&pdev->dev);
>  
> -- 
> 2.34.1
>