Re: [PATCH 00/10] drm/{i915, xe}: use a shared gtt_view_types.h header

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Sep 15, 2026 at 11:09:11PM +0300, Jani Nikula wrote:
> Move i915_gtt_view_types.h under include/drm/intel, and clean up.
> 
> Jani Nikula (10):
>   drm/intel: move i915_gtt_view_types.h to include/drm/intel
>   drm/intel: rename i915_gtt_view_is_*() helpers to
>     intel_gtt_view_is_*()
>   drm/intel: rename i915_gtt_view* struct/enum to intel_gtt_view*
>   drm/intel: add intel_gtt_view_is_partial() for completeness
>   drm/xe/display: use intel_gtt_view_is_*() helpers more
>   drm/i915/gem: use intel_gtt_view_is_*() helpers more
>   drm/i915/vma: use intel_gtt_view_is_*() helpers more
>   drm/i915/selftests: use intel_gtt_view_is_*() helpers more
>   drm/i915/debugfs: use the intel_gtt_view_is_*() helpers more
>   drm/intel: rename I915_GTT_VIEW_* enumerations to INTEL_GTT_VIEW_*

I did a quick rebase of my wip tile ys/64 stuff on top of it and
didn't spot anything bad. Spotted a couple of small nits (one in
the header and another in the selftests) to which I replied
separately.

Apart from that the series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
>  .../drm/i915/display/intel_display_types.h    |  4 +-
>  drivers/gpu/drm/i915/display/intel_fb.c       | 18 +++---
>  drivers/gpu/drm/i915/display/intel_parent.c   |  4 +-
>  drivers/gpu/drm/i915/display/intel_parent.h   |  6 +-
>  drivers/gpu/drm/i915/gem/i915_gem_domain.c    |  4 +-
>  drivers/gpu/drm/i915/gem/i915_gem_mman.c      | 14 ++---
>  drivers/gpu/drm/i915/gem/i915_gem_object.h    |  2 +-
>  .../drm/i915/gem/selftests/i915_gem_mman.c    |  4 +-
>  drivers/gpu/drm/i915/i915_debugfs.c           | 20 ++-----
>  drivers/gpu/drm/i915/i915_gem.c               |  6 +-
>  drivers/gpu/drm/i915/i915_gem.h               |  6 +-
>  drivers/gpu/drm/i915/i915_vma.c               | 44 +++++---------
>  drivers/gpu/drm/i915/i915_vma.h               | 12 ++--
>  drivers/gpu/drm/i915/i915_vma_types.h         | 29 +++++----
>  drivers/gpu/drm/i915/selftests/i915_vma.c     | 60 +++++++++----------
>  .../compat-i915-headers/i915_gtt_view_types.h |  7 ---
>  drivers/gpu/drm/xe/display/xe_fb_pin.c        | 28 ++++-----
>  include/drm/intel/display_parent_interface.h  |  8 +--
>  .../drm/intel/gtt_view_types.h                | 37 +++++++-----
>  19 files changed, 143 insertions(+), 170 deletions(-)
>  delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_gtt_view_types.h
>  rename drivers/gpu/drm/i915/i915_gtt_view_types.h => include/drm/intel/gtt_view_types.h (50%)
> 
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel