From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Yitian Shao <fighters390@qq.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
jani.nikula@intel.com, sebastian.wick@redhat.com,
uma.shankar@intel.com, suraj.kandpal@intel.com
Subject: Re: [PATCH v3 1/4] drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip()
Date: Sat, 21 Nov 2026 03:13:51 +0200 [thread overview]
Message-ID: <awDwT7DapivUsFJf@intel.com> (raw)
In-Reply-To: <tencent_B90E2647114BCF037778DE0C967949C0E908@qq.com>
On Sat, Nov 21, 2026 at 08:54:06AM +0800, Yitian Shao wrote:
> intel_dp_has_gamut_metadata_dip() returns false for LSPCON encoders, which
> is not what the function is asking. LSPCON does send the HDR metadata
> infoframe, only through lspcon_write_infoframe() instead of the transcoder
> DIP.
lspcon_write_infoframe() does use the same DIP for this, so this
statement is a bit confusing. I guess we just want to say something
along the lines that the DIP does exist regardless of whether
LSPCON is used or not.
Otherwise this looks good.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The check only existed to keep intel_dp_add_properties() from attaching
> HDR_OUTPUT_METADATA before intel_lspcon_detect_hdr_capability() has probed
> the hardware. Move that check to intel_dp_add_properties() where the
> attach decision is made.
>
> Signed-off-by: Yitian Shao <fighters390@qq.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index afd4169..2736a78 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -6672,9 +6672,6 @@ intel_dp_has_gamut_metadata_dip(struct intel_encoder *encoder)
> struct intel_display *display = to_intel_display(encoder);
> enum port port = encoder->port;
>
> - if (intel_bios_encoder_is_lspcon(encoder->devdata))
> - return false;
> -
> if (DISPLAY_VER(display) >= 11)
> return true;
>
> @@ -6715,7 +6712,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *_connec
> intel_attach_dp_colorspace_property(&connector->base);
> }
>
> - if (intel_dp_has_gamut_metadata_dip(&dp_to_dig_port(intel_dp)->base))
> + /* LSPCON attaches the property itself in intel_dp_connector_register() */
> + if (!intel_bios_encoder_is_lspcon(dp_to_dig_port(intel_dp)->base.devdata) &&
> + intel_dp_has_gamut_metadata_dip(&dp_to_dig_port(intel_dp)->base))
> drm_connector_attach_hdr_output_metadata_property(&connector->base);
>
> if (HAS_VRR(display))
> --
> 2.53.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-11-21 1:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261121005409.17626-1-fighters390@qq.com>
2026-11-21 0:54 ` [PATCH v3 1/4] drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip() Yitian Shao
2026-11-21 1:13 ` Ville Syrjälä [this message]
2026-11-21 0:54 ` [PATCH v3 2/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP with TCON HDR support Yitian Shao
2026-11-21 1:20 ` Ville Syrjälä
2026-11-21 0:54 ` [PATCH v3 3/4] drm/i915/display: Check gamut metadata DIP support in LSPCON HDR detection Yitian Shao
2026-11-21 1:21 ` Ville Syrjälä
2026-11-21 0:54 ` [PATCH v3 4/4] drm/i915/dp: Prefer SDP over DPCD for HDR content luminance Yitian Shao
2026-11-21 1:28 ` Ville Syrjälä
2026-11-21 1:06 ` ✗ LGCI.VerificationFailed: failure for series starting with [v3,1/4] drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip() Patchwork
2026-11-21 1:17 ` [PATCH v3 0/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP Yitian Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awDwT7DapivUsFJf@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fighters390@qq.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=sebastian.wick@redhat.com \
--cc=suraj.kandpal@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox