From: "Souza, Jose" <jose.souza@intel.com>
To: "Roper, Matthew D" <matthew.d.roper@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/ehl: Update MOCS table for EHL
Date: Thu, 13 Jun 2019 22:27:04 +0000 [thread overview]
Message-ID: <b13e3a5b45bf74cd212b9fbcb529fe95a680bea3.camel@intel.com> (raw)
In-Reply-To: <20190530234014.22340-1-matthew.d.roper@intel.com>
On Thu, 2019-05-30 at 16:40 -0700, Matt Roper wrote:
> EHL defines two new MOCS table entries but is otherwise compatible
> with
> the ICL MOCS table.
>
> These table entries (16 and 17) should still be considered unused for
> ICL and as such their behavior remains undefined for that platform.
>
Requesting another CI round before merging it.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_mocs.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c
> b/drivers/gpu/drm/i915/gt/intel_mocs.c
> index 79df66022d3a..1f9db50b1869 100644
> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> @@ -200,6 +200,14 @@ static const struct drm_i915_mocs_entry
> broxton_mocs_table[] = {
> MOCS_ENTRY(15, \
> LE_3_WB | LE_TC_1_LLC | LE_LRUM(2) | LE_AOM(1), \
> L3_3_WB), \
> + /* Bypass LLC - Uncached (EHL+) */ \
> + MOCS_ENTRY(16, \
> + LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
> + L3_1_UC), \
> + /* Bypass LLC - L3 (Read-Only) (EHL+) */ \
> + MOCS_ENTRY(17, \
> + LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
> + L3_3_WB), \
> /* Self-Snoop - L3 + LLC */ \
> MOCS_ENTRY(18, \
> LE_3_WB | LE_TC_1_LLC | LE_LRUM(3) | LE_SSE(3), \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-13 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 23:40 [PATCH] drm/i915/ehl: Update MOCS table for EHL Matt Roper
2019-05-31 13:36 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-01 6:22 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-06-03 21:14 ` Matt Roper
2019-06-06 20:10 ` [PATCH] " Lucas De Marchi
2019-06-13 22:27 ` Souza, Jose [this message]
2019-06-15 15:23 ` Matt Roper
2019-06-14 13:18 ` ✓ Fi.CI.BAT: success for drm/i915/ehl: Update MOCS table for EHL (rev2) Patchwork
2019-06-15 9:43 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b13e3a5b45bf74cd212b9fbcb529fe95a680bea3.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox