Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: add back the selftest() hook for the buddy

[Matthew Auld <matthew.auld@intel.com>]

On 18/06/2021 14:36, Thomas Hellström wrote:
> Hi.
> 
> On 6/18/21 3:31 PM, Matthew Auld wrote:
>> When we resurrected the selftest we forgot to add back the selftest()
>> hook, meaning the test is not currently run.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> 
> Do we need a Fixes: tag?

Not completely sure since this is just for the selftests, so should have 
zero impact for "normal" users, and so also no need to backport or queue 
for fixes I think. I'll add a References: link.

> 
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> 
> 
>> ---
>>   drivers/gpu/drm/i915/selftests/i915_mock_selftests.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h 
>> b/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
>> index 34e5caf38093..6759b56086fb 100644
>> --- a/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
>> +++ b/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
>> @@ -34,3 +34,4 @@ selftest(gtt, i915_gem_gtt_mock_selftests)
>>   selftest(hugepages, i915_gem_huge_page_mock_selftests)
>>   selftest(contexts, i915_gem_context_mock_selftests)
>>   selftest(memory_region, intel_memory_region_mock_selftests)
>> +selftest(buddy, i915_buddy_mock_selftests)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx