From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private
Date: Sun, 28 May 2023 14:58:15 +0000 [thread overview]
Message-ID: <b1ed5adb83b7fa0ea50f7a902356dd673d3e94aa.camel@intel.com> (raw)
In-Reply-To: <87mt1rib2x.fsf@intel.com>
On Fri, 2023-05-26 at 14:30 +0300, Jani Nikula wrote:
> On Wed, 24 May 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> > On 24/05/2023 10:05, Luca Coelho wrote:
> > > In order to avoid flush_scheduled_work() usage, add a dedicated
> > > workqueue in the drm_i915_private structure. In this way, we don't
> > > need to use the system queue anymore.
> > >
> > > This change is mostly mechanical and based on Tetsuo's original
> > > patch[1].
> > >
> > > Link: https://patchwork.freedesktop.org/series/114608/ [1]
> > > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_display.c | 5 ++--
> > > .../drm/i915/display/intel_display_driver.c | 2 +-
> > > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +-
> > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> > > .../drm/i915/display/intel_dp_link_training.c | 3 ++-
> > > drivers/gpu/drm/i915/display/intel_drrs.c | 4 +++-
> > > drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
> > > drivers/gpu/drm/i915/display/intel_fbdev.c | 3 ++-
> > > drivers/gpu/drm/i915/display/intel_hdcp.c | 23 +++++++++++--------
> > > drivers/gpu/drm/i915/display/intel_hotplug.c | 18 ++++++++++-----
> > > drivers/gpu/drm/i915/display/intel_opregion.c | 3 ++-
> > > drivers/gpu/drm/i915/display/intel_pps.c | 4 +++-
> > > drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++---
> > > .../drm/i915/gt/intel_execlists_submission.c | 5 ++--
> > > .../gpu/drm/i915/gt/intel_gt_buffer_pool.c | 10 ++++----
> > > drivers/gpu/drm/i915/gt/intel_gt_irq.c | 2 +-
> > > drivers/gpu/drm/i915/gt/intel_gt_requests.c | 10 ++++----
> > > drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
> > > drivers/gpu/drm/i915/gt/intel_rps.c | 20 ++++++++--------
> > > drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 2 +-
> > > drivers/gpu/drm/i915/i915_driver.c | 11 +++++++++
> > > drivers/gpu/drm/i915/i915_drv.h | 9 +++++++-
> > > drivers/gpu/drm/i915/i915_request.c | 2 +-
> > > drivers/gpu/drm/i915/intel_wakeref.c | 2 +-
> > > 24 files changed, 99 insertions(+), 55 deletions(-)
> >
> > I'll take a look at the gt/ parts only since display experts need to
> > okay the point Daniel raise anyway.
>
> There's a bunch of lockdep failures in BAT. Are they possible related to
> switching to unordered wq?
I have not checked those results yet, because I'll send a new version
soon anyway. I tested this before, but with the dedicated wakeref
workqueues, and it all passed cleanly. So it _may_ be related to that
change. I'll check it.
--
Cheers,
Luca.
next prev parent reply other threads:[~2023-05-28 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 9:05 [Intel-gfx] [PATCH v2 0/3] drm/i915: implement internal workqueues Luca Coelho
2023-05-24 9:05 ` [Intel-gfx] [PATCH v2 1/3] drm/i915: use pointer to i915 instead of rpm in wakeref Luca Coelho
2023-05-24 10:42 ` Tvrtko Ursulin
2023-05-26 10:43 ` Jani Nikula
2023-05-24 9:05 ` [Intel-gfx] [PATCH v2 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private Luca Coelho
2023-05-24 11:00 ` Tvrtko Ursulin
2023-05-24 11:05 ` Tvrtko Ursulin
2023-05-24 12:25 ` Coelho, Luciano
2023-05-26 11:30 ` Jani Nikula
2023-05-28 14:58 ` Coelho, Luciano [this message]
2023-05-24 9:05 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/selftests: add local workqueue for SW fence selftest Luca Coelho
2023-05-24 11:01 ` Tvrtko Ursulin
2023-05-24 11:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement internal workqueues (rev2) Patchwork
2023-05-24 11:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-24 11:18 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1ed5adb83b7fa0ea50f7a902356dd673d3e94aa.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox