Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Deak, Imre" <imre.deak@intel.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Manna, Animesh" <animesh.manna@intel.com>
Subject: Re: [PATCH] drm/i915/dp_mst: Disable Panel Replay
Date: Fri, 7 Nov 2025 13:54:51 +0000	[thread overview]
Message-ID: <b23c2ff042f4e52658cd58234d1925c440c0f4e8.camel@intel.com> (raw)
In-Reply-To: <20251107124141.911895-1-imre.deak@intel.com>

On Fri, 2025-11-07 at 14:41 +0200, Imre Deak wrote:
> Disable Panel Replay on MST links until it's properly implemented.
> For
> instance the required VSC SDP is not programmed on MST and FEC is not
> enabled if Panel Replay is enabled.
> 
> Fixes: 3257e55d3ea7 ("drm/i915/panelreplay: enable/disable panel
> replay")
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15174
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: Animesh Manna <animesh.manna@intel.com>
> Cc: stable@vger.kernel.org # v6.8+
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 05014ffe3ce1d..54fc30cfad84c 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -626,6 +626,10 @@ static void _panel_replay_init_dpcd(struct
> intel_dp *intel_dp)
>  	struct intel_display *display = to_intel_display(intel_dp);
>  	int ret;
>  
> +	/* TODO: Enable Panel Replay on MST once it's properly
> implemented. */
> +	if (intel_dp->mst_detect == DRM_DP_MST)
> +		return;
> +
>  	ret = drm_dp_dpcd_read_data(&intel_dp->aux,
> DP_PANEL_REPLAY_CAP_SUPPORT,
>  				    &intel_dp->pr_dpcd,
> sizeof(intel_dp->pr_dpcd));
>  	if (ret < 0)


  reply	other threads:[~2025-11-07 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 12:41 [PATCH] drm/i915/dp_mst: Disable Panel Replay Imre Deak
2025-11-07 13:54 ` Hogander, Jouni [this message]
2025-11-07 14:10 ` ✓ i915.CI.BAT: success for " Patchwork
2025-11-08  5:13 ` ✓ i915.CI.Full: " Patchwork
2025-11-10 16:11   ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b23c2ff042f4e52658cd58234d1925c440c0f4e8.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox