Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Sean Paul <sean@poorly.run>,
	Kevin Strasser <kevin.strasser@intel.com>
Cc: dim-tools@lists.freedesktop.org,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PULL] topic/hdr-formats
Date: Mon, 11 Mar 2019 13:52:13 -0400	[thread overview]
Message-ID: <b2b0220c9b856f46a49bfb7ed9274f18e81da166.camel@redhat.com> (raw)
In-Reply-To: <b3cd478a-de5e-3683-7e46-84ea37be8c7b@linux.intel.com>

On Mon, 2019-03-11 at 12:19 +0100, Maarten Lankhorst wrote:
> Hey,
> 
> Op 07-03-2019 om 18:12 schreef Adam Jackson:
> > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
> > > Hi Sean and Joonas,
> > > 
> > > Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> > Could you also add Kevin Strasser's patch for FP16 formats? For that
> > matter I'd like to see FP32 added too, but I don't think there's been a
> > patch sent for that yet.
> 
> Added kevin to CC.
> 
> Is the mesa side considered completely reviewed then?

Is that strictly necessary for just adding a fourcc? I get wanting to
see a real userspace consumer first, but this is just allocating some
magic numbers not promising that a certain ioctl behaves a certain way.

That said, I did say r-b for the Mesa series as a whole. Daniel Stone
had some comments on 13/13 that made it sound like it (that specific
patch) was unnecessary/undesirable, but everything before that looked
great to me, and even if we only merged the first 12 we'd still have
FP16 wired through for the gbm EGL platform, meaning HDR scanout could
actually be a thing.

- ajax

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-03-11 17:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07  9:48 [PULL] topic/hdr-formats Maarten Lankhorst
2019-03-07 17:12 ` Adam Jackson
2019-03-11 11:19   ` Maarten Lankhorst
2019-03-11 17:52     ` Adam Jackson [this message]
2019-03-11 18:02       ` Daniel Vetter
2019-03-07 17:46 ` Sean Paul
2019-03-08 12:45   ` Maarten Lankhorst
2019-03-08 15:40 ` Sean Paul
2019-03-11 11:57 ` Joonas Lahtinen
2019-03-11 12:05   ` Maarten Lankhorst
  -- strict thread matches above, loose matches on Subject: below --
2019-03-13 11:21 Maarten Lankhorst
2019-03-13 18:20 ` Sean Paul
2019-03-18 15:22 ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2b0220c9b856f46a49bfb7ed9274f18e81da166.camel@redhat.com \
    --to=ajax@redhat.com \
    --cc=dim-tools@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kevin.strasser@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox