From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Tvrtko Ursulin <tursulin@ursulin.net>
Cc: intel-gfx <Intel-gfx@lists.freedesktop.org>
Subject: Re: [RFC i-g-t 1/2] extended.testlist: Remove default and render engine test duplicates
Date: Thu, 22 Jun 2017 11:45:40 +0100 [thread overview]
Message-ID: <b3533988-d6f6-4fd9-298a-0824a9b3156f@linux.intel.com> (raw)
In-Reply-To: <CAKMK7uEgr-Hi0bc9iDA53gKfmZQdTL0eL11RA-8z86Qbu46kig@mail.gmail.com>
On 22/06/2017 10:54, Daniel Vetter wrote:
> On Fri, Jun 16, 2017 at 12:55 PM, Tvrtko Ursulin <tursulin@ursulin.net> wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Where there is both default and render for the same test,
>> remove the former to save some execution time.
>
> If they are redundant, why do we even have them? Can we just remove
Maybe we can remove the default entry from intel_execution_engines
array? And just test that default == render explicitly in a few short tests.
> the testcase itself? Accumulating unused tests of questionable use at
> best in igt is serious pain, because it means we never can get to a
> world where new testcases are auto-added to CI withou some manual
> review. And that's the world of pain we live in now and I really want
> to get out of it. That means reviewing and removing testcases, not
> massaging courated testlists forever, I don't think we have the time
> for that among all the other tasks.
>
> </rant> :-)
I am not a fan of the testlist neither, but thought to avoid letting
perfect being the enemy of good, and at least do something until the
final solution crystallizes.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-22 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 10:55 [RFC i-g-t 1/2] extended.testlist: Remove default and render engine test duplicates Tvrtko Ursulin
2017-06-16 10:55 ` [RFC i-g-t 2/2] extended.testlist: Remove some test-subtest combinations Tvrtko Ursulin
2017-06-16 11:01 ` Chris Wilson
2017-06-16 16:00 ` [RFC i-g-t 1/2] extended.testlist: Remove default and render engine test duplicates Chris Wilson
2017-06-22 9:54 ` Daniel Vetter
2017-06-22 10:45 ` Tvrtko Ursulin [this message]
2017-06-23 11:14 ` Daniel Vetter
2017-06-23 11:21 ` Chris Wilson
2017-06-26 16:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3533988-d6f6-4fd9-298a-0824a9b3156f@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox