From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
intel-gfx@lists.freedesktop.org
Cc: Pallavi Mishra <pallavi.mishra@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check
Date: Thu, 4 May 2023 20:54:48 +0200 [thread overview]
Message-ID: <b4f555bc-c20c-a2ea-87e3-318a0ababd2c@linux.intel.com> (raw)
In-Reply-To: <20230504102805.18645-1-juhapekka.heikkila@gmail.com>
On 5/4/2023 12:28 PM, Juha-Pekka Heikkila wrote:
> From: Pallavi Mishra <pallavi.mishra@intel.com>
>
> Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus
> enabling MTL to use it.
>
> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
I think should fix the mtl migrate selftest failure.
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13108/bat-mtlp-6/igt@i915_selftest@live@migrate.html#dmesg-warnings745
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 3f638f198796..e0998879a0e1 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -920,7 +920,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
>
> GEM_BUG_ON(size >> PAGE_SHIFT > S16_MAX);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12)
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
> ring_sz = XY_FAST_COLOR_BLT_DW;
> else if (ver >= 8)
> ring_sz = 8;
> @@ -931,7 +931,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
> if (IS_ERR(cs))
> return PTR_ERR(cs);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12) {
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> *cs++ = XY_FAST_COLOR_BLT_CMD | XY_FAST_COLOR_BLT_DEPTH_32 |
> (XY_FAST_COLOR_BLT_DW - 2);
> *cs++ = FIELD_PREP(XY_FAST_COLOR_BLT_MOCS_MASK, mocs) |
next prev parent reply other threads:[~2023-05-04 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs Juha-Pekka Heikkila
2023-05-04 20:15 ` Sripada, Radhakrishna
2023-05-05 8:38 ` Andi Shyti
2023-05-04 10:28 ` [Intel-gfx] [PATCH 3/4] drm/fourcc: define Intel Meteorlake related ccs modifiers Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL " Juha-Pekka Heikkila
2023-05-08 11:41 ` Kahola, Mika
2023-05-09 11:58 ` Juha-Pekka Heikkila
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check Patchwork
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-04 18:54 ` Das, Nirmoy [this message]
2023-05-04 19:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-04 21:24 ` [Intel-gfx] [PATCH 1/4] " Andrzej Hajda
2023-05-05 8:36 ` Andi Shyti
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2) Patchwork
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-05 19:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-06 13:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f555bc-c20c-a2ea-87e3-318a0ababd2c@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=pallavi.mishra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox