Re: [PATCH 2/3] drm/i915/hdcp: Pin the hdcp gsc message high in ggtt

[Andrzej Hajda <andrzej.hajda@intel.com>]

On 15.12.2023 12:09, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> AFAICS there is no hardware restriction on where in ggtt
> the hdcp gsc message object needs to be bound. And as it's
> a regular shmem object we don't need it be in the mappabe
> range either. So pin it high to make avoid needlessly
> wasting the precious mappable range for it.
> 
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards
Andrzej

> ---
>   drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> index 18117b789b16..302bff75b06c 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> @@ -65,7 +65,7 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915,
>   		goto out_unmap;
>   	}
>   
> -	err = i915_vma_pin(vma, 0, 0, PIN_GLOBAL);
> +	err = i915_vma_pin(vma, 0, 0, PIN_GLOBAL | PIN_HIGH);
>   	if (err)
>   		goto out_unmap;
>