public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Bloomfield, Jon" <jon.bloomfield@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"Taylor, Clinton A" <clinton.a.taylor@intel.com>
Cc: "Intel-gfx@lists.freedesktop.org" <Intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/adlp: Remove require_force_probe protection
Date: Sat, 4 Dec 2021 00:28:30 +0000	[thread overview]
Message-ID: <b5c438f0b05b41ffbd9dbfcba26467d9@intel.com> (raw)
In-Reply-To: <YZQxlF5B0kcqzJvO@intel.com>

Assuming the whitespace cleanup requested below is completed:

Acked-by: Jon Bloomfield <jon.bloomfield@intel.com>

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Rodrigo Vivi
> Sent: Tuesday, November 16, 2021 2:33 PM
> To: Taylor, Clinton A <clinton.a.taylor@intel.com>
> Cc: Intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/adlp: Remove
> require_force_probe protection
> 
> On Mon, Nov 15, 2021 at 03:53:45PM -0800, clinton.a.taylor@intel.com
> wrote:
> > From: Clint Taylor <clinton.a.taylor@intel.com>
> >
> >     drm/i915/adlp: Remove require_force_probe protection
> >
> >     Removing force probe protection from ADL_P platform. Did
> >     not observe warnings, errors, flickering or any visual
> >     defects while doing ordinary tasks like browsing and
> >     editing documents in a two monitor setup.
> 
> some strange alignment here... please remove the extra
> tabs here.
> 
> >
> >     For more info drm-tip idle run results :
> >     https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html?
> 
> hmm... I could swear that I had seen the ADL-P green there a few
> days ago as well... But right now I couldn't see ADL-P there...
> 
> So that fails on having a *reliable* green CI picture...
> Any idea why that is down at this moment?
> 
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_pci.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c
> b/drivers/gpu/drm/i915/i915_pci.c
> > index 4c7fcc5f9a97..af9f4988bd88 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -970,7 +970,6 @@ static const struct intel_device_info adl_p_info = {
> >  	GEN12_FEATURES,
> >  	XE_LPD_FEATURES,
> >  	PLATFORM(INTEL_ALDERLAKE_P),
> > -	.require_force_probe = 1,
> >  	.cpu_transcoder_mask = BIT(TRANSCODER_A) |
> BIT(TRANSCODER_B) |
> >  			       BIT(TRANSCODER_C) | BIT(TRANSCODER_D) |
> >  			       BIT(TRANSCODER_DSI_0) |
> BIT(TRANSCODER_DSI_1),
> > --
> > 2.33.1
> >

      reply	other threads:[~2021-12-04  0:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 23:53 [Intel-gfx] [PATCH] drm/i915/adlp: Remove require_force_probe protection clinton.a.taylor
2021-11-16  0:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-11-16  0:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-16  1:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-16 22:32 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2021-12-04  0:28   ` Bloomfield, Jon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5c438f0b05b41ffbd9dbfcba26467d9@intel.com \
    --to=jon.bloomfield@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=clinton.a.taylor@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox