public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [RESEND 0/4] drm/i915: add dedicated lock for each sideband
Date: Tue, 29 Oct 2024 11:16:13 +0000	[thread overview]
Message-ID: <b8c94f1da0b0da9b5dadbe01dd11772d02bb53d1.camel@intel.com> (raw)
In-Reply-To: <cover.1730193891.git.jani.nikula@intel.com>

On Tue, 2024-10-29 at 11:25 +0200, Jani Nikula wrote:
> It's misleading to use the same sideband mutex for LPT/WPT IOSF,
> VLV/CHV
> IOSF, and punit. Add dedicated locks for clarity.

For the whole series:

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

> 
> Jani Nikula (4):
>   drm/i915/sbi: add intel_sbi_{lock,unlock}()
>   drm/i915/sbi: add a dedicated mutex for LPT/WPT IOSF sideband
>   drm/i915: add a dedicated mutex for VLV/CHV IOSF sideband
>   drm/i915: hide VLV PUNIT IOSF sideband qos handling better
> 
>  .../gpu/drm/i915/display/intel_pch_refclk.c   | 26 ++++++++---------
>  drivers/gpu/drm/i915/i915_driver.c            |  8 ++++--
>  drivers/gpu/drm/i915/i915_drv.h               | 10 ++++++-
>  drivers/gpu/drm/i915/intel_sbi.c              | 22 ++++++++++++++-
>  drivers/gpu/drm/i915/intel_sbi.h              |  4 +++
>  drivers/gpu/drm/i915/vlv_sideband.c           | 28 +++++++++++++++--
> --
>  drivers/gpu/drm/i915/vlv_sideband.h           |  3 ++
>  7 files changed, 79 insertions(+), 22 deletions(-)
> 


  parent reply	other threads:[~2024-10-29 11:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29  9:25 [RESEND 0/4] drm/i915: add dedicated lock for each sideband Jani Nikula
2024-10-29  9:25 ` [RESEND 1/4] drm/i915/sbi: add intel_sbi_{lock,unlock}() Jani Nikula
2024-10-29  9:25 ` [RESEND 2/4] drm/i915/sbi: add a dedicated mutex for LPT/WPT IOSF sideband Jani Nikula
2024-10-29  9:25 ` [RESEND 3/4] drm/i915: add a dedicated mutex for VLV/CHV " Jani Nikula
2024-10-29  9:25 ` [RESEND 4/4] drm/i915: hide VLV PUNIT IOSF sideband qos handling better Jani Nikula
2024-10-29 11:16 ` Hogander, Jouni [this message]
2024-11-05 11:05   ` [RESEND 0/4] drm/i915: add dedicated lock for each sideband Jani Nikula
2024-10-29 18:50 ` ✗ Fi.CI.SPARSE: warning for drm/i915: add dedicated lock for each sideband (rev2) Patchwork
2024-10-29 19:16 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-30  0:15 ` ✗ Fi.CI.SPARSE: warning for drm/i915: add dedicated lock for each sideband (rev3) Patchwork
2024-10-30  0:24 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-30  9:13   ` Jani Nikula
2024-10-30 12:59     ` Jani Nikula
2024-11-04  6:50       ` Illipilli, TejasreeX
2024-11-04  6:35 ` ✓ Fi.CI.BAT: success " Patchwork
2024-11-04 11:49 ` ✗ Fi.CI.SPARSE: warning for drm/i915: add dedicated lock for each sideband (rev4) Patchwork
2024-11-04 12:51 ` ✓ Fi.CI.BAT: success " Patchwork
2024-11-04 22:04 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8c94f1da0b0da9b5dadbe01dd11772d02bb53d1.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox