From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 1/3] drm/i915: Rework some interrupt handling functions to take intel_gt
Date: Tue, 2 Jul 2019 12:45:27 +0100 [thread overview]
Message-ID: <b9165546-24fb-ee6e-32dd-d0ea70b86968@linux.intel.com> (raw)
In-Reply-To: <156206365237.2466.8976003981692121208@skylake-alporthouse-com>
On 02/07/2019 11:34, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-07-02 11:23:11)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Some interrupt handling functions already have gt in their names
>> suggesting them as obvious candidates to make them take struct intel_gt
>> instead of i915.
>>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> Co-authored-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>
>> static void
>> -gen11_other_irq_handler(struct drm_i915_private * const i915,
>> - const u8 instance, const u16 iir)
>> +gen11_other_irq_handler(struct intel_gt *gt, const u8 instance,
>> + const u16 iir)
>> {
>> + struct drm_i915_private *i915 = gt->i915;
>> +
>> if (instance == OTHER_GUC_INSTANCE)
>> return gen11_guc_irq_handler(i915, iir);
>
> That looks like a candidate for gt as well. Even for the guc, the
> interrupt vector is GT centric. I was hoping we could place guc/ parallel
> to gt/, but it looks like it will indeed be a child of intel_gt.
Yeah. Daniele will deal with the GuC code paths.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks. I'll also let Daniele comment on whether this refactoring fits
with his work before merging it.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-02 11:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 10:23 [PATCH 0/3] More mmio and intel_gt cleanups and refactorings Tvrtko Ursulin
2019-07-02 10:23 ` [PATCH 1/3] drm/i915: Rework some interrupt handling functions to take intel_gt Tvrtko Ursulin
2019-07-02 10:34 ` Chris Wilson
2019-07-02 11:45 ` Tvrtko Ursulin [this message]
2019-07-02 17:14 ` Daniele Ceraolo Spurio
2019-07-02 10:23 ` [PATCH 2/3] drm/i915: Remove some legacy mmio accessors from interrupt handling Tvrtko Ursulin
2019-07-02 10:36 ` Chris Wilson
2019-07-02 10:23 ` [PATCH 3/3] drm/i915: Move dev_priv->pm_i{m, e}r into intel_gt Tvrtko Ursulin
2019-07-02 10:32 ` Chris Wilson
2019-07-02 10:46 ` ✗ Fi.CI.CHECKPATCH: warning for More mmio and intel_gt cleanups and refactorings Patchwork
2019-07-02 10:51 ` Chris Wilson
2019-07-02 11:06 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-07-03 6:25 ` ✗ Fi.CI.BAT: failure for More mmio and intel_gt cleanups and refactorings (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9165546-24fb-ee6e-32dd-d0ea70b86968@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox