From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 3/5] drm/i915: Kill off now unused gen6+ AGP code
Date: Fri, 02 Nov 2012 12:28:26 +0000 [thread overview]
Message-ID: <b94cdc$76inat@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1351790643-4626-3-git-send-email-ben@bwidawsk.net>
On Thu, 1 Nov 2012 10:24:01 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> @@ -1269,22 +1108,8 @@ static int i9xx_setup(void)
> pci_read_config_dword(intel_private.pcidev,
> I915_PTEADDR, >t_addr);
> intel_private.gtt_bus_addr = gtt_addr;
> - } else {
> - u32 gtt_offset;
> -
> - switch (INTEL_GTT_GEN) {
> - case 5:
> - case 6:
> - case 7:
> - gtt_offset = MB(2);
> - break;
> - case 4:
> - default:
> - gtt_offset = KB(512);
> - break;
> - }
> - intel_private.gtt_bus_addr = reg_addr + gtt_offset;
> - }
> + } else
> + intel_private.gtt_bus_addr = reg_addr + KB(512);
We still need to handle GEN==5 here which has a MB(2) GTT.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-02 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 17:23 [PATCH 1/5 v4] drm/i915: Stop using AGP layer for GEN6+ Ben Widawsky
2012-11-01 17:24 ` [PATCH 2/5] drm/i915: Calculate correct stolen size for GEN7+ Ben Widawsky
2012-11-01 17:24 ` [PATCH 3/5] drm/i915: Kill off now unused gen6+ AGP code Ben Widawsky
2012-11-02 12:28 ` Chris Wilson [this message]
2012-11-01 17:24 ` [PATCH 4/5] drm/i915: flush system agent TLBs on SNB Ben Widawsky
2012-11-01 17:24 ` [PATCH 5/5] drm/i915: Move the remaining gtt code Ben Widawsky
2012-11-02 12:30 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$76inat@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox