From: Andrzej Hajda <andrzej.hajda@intel.com>
To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: adjust saturated-hostile test timeout
Date: Fri, 23 Sep 2022 18:06:28 +0200 [thread overview]
Message-ID: <b96aed3b-4164-e5ea-5c2b-f975ae5ad1b7@intel.com> (raw)
In-Reply-To: <20220922081353.1759082-1-andrzej.hajda@intel.com>
On 22.09.2022 10:13, Andrzej Hajda wrote:
> GPU occasionally can hang during saturated-hostile test. Detection of
> such case and reset can take up to 5 seconds. While at it fix typo in
> definition of RESET_TIMEOUT_MS.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Please ignore the patch, it has been superseded by:
https://patchwork.freedesktop.org/patch/504450/
Regards
Andrzej
> ---
> tests/i915/gem_ctx_persistence.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
> index 50196edb19f..603fdd84438 100644
> --- a/tests/i915/gem_ctx_persistence.c
> +++ b/tests/i915/gem_ctx_persistence.c
> @@ -46,7 +46,8 @@
> #include "intel_allocator.h"
> #include "sw_sync.h"
>
> -#define RESET_TIMEOUT_MS 2 * MSEC_PER_SEC; /* default: 640ms */
> +#define RESET_TIMEOUT_MS (2 * MSEC_PER_SEC) /* default: 640ms */
> +#define RESET_TIMEOUT_GPU_HANG_MS (10000 * MSEC_PER_SEC)
> static unsigned long reset_timeout_ms = RESET_TIMEOUT_MS;
> #define NSEC_PER_MSEC (1000 * 1000ull)
>
> @@ -370,7 +371,7 @@ static void test_nohangcheck_hostile(int i915, const intel_ctx_cfg_t *cfg)
> igt_require(__enable_hangcheck(dir, false));
>
> for_each_ctx_cfg_engine(i915, cfg, e) {
> - int64_t timeout = 10000 * NSEC_PER_MSEC;
> + int64_t timeout = RESET_TIMEOUT_GPU_HANG_MS;
> const intel_ctx_t *ctx = intel_ctx_create(i915, cfg);
> uint64_t ahnd = get_reloc_ahnd(i915, ctx->id);
> igt_spin_t *spin;
> @@ -951,7 +952,7 @@ test_saturated_hostile_all(int i915, const intel_ctx_t *base_ctx,
> intel_ctx_destroy(i915, ctx);
>
> /* Hostile request requires a GPU reset to terminate */
> - igt_assert_eq(wait_for_status(spin->out_fence, reset_timeout_ms), -EIO);
> + igt_assert_eq(wait_for_status(spin->out_fence, RESET_TIMEOUT_GPU_HANG_MS), -EIO);
>
> /* All other spinners should be left unharmed */
> gem_quiescent_gpu(i915);
prev parent reply other threads:[~2022-09-23 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 8:13 [Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: adjust saturated-hostile test timeout Andrzej Hajda
2022-09-23 16:06 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96aed3b-4164-e5ea-5c2b-f975ae5ad1b7@intel.com \
--to=andrzej.hajda@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox