From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/10] drm/i915/lvds: Introduce intel_lvds_connector
Date: Fri, 22 Apr 2011 19:07:39 +0100 [thread overview]
Message-ID: <b9dded$irdv0c@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20110422175046.GD27642@bwgnt.jf.intel.com>
On Fri, 22 Apr 2011 10:50:47 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> How about to save some eyestrain, using some macro helpers?
>
> struct intel_lvds_connector {
> struct intel_connector base;
> #define drm_base \
> base.base
> #define drm_dev \
> drm_base.dev
> #define drm_funcs \
> drm_base.funcs
> };
>
> Similarly with lvds_encoder, and intel_dp structures if you so desire.
I'm always a little wary about macros to hide details of the structure,
they make the relationships less discoverable.
Fortunately, by the end of the series most of the eye sores have gone.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-22 18:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 9:19 Share common logic between eDP and LVDS in panel Chris Wilson
2011-04-22 9:19 ` [PATCH 01/10] drm/i915/lvds: Rename intel_lvds to intel_lvds_encoder Chris Wilson
2011-04-22 16:18 ` Jesse Barnes
2011-04-22 9:19 ` [PATCH 02/10] drm/i915/lvds: Introduce intel_lvds_connector Chris Wilson
2011-04-22 16:18 ` Jesse Barnes
2011-04-22 17:50 ` Ben Widawsky
2011-04-22 18:07 ` Chris Wilson [this message]
2011-04-22 9:19 ` [PATCH 03/10] drm/i915/lvds: Move the acpi_lid_notifier from drm_i915_private to the connector Chris Wilson
2011-04-22 16:19 ` Jesse Barnes
2011-04-22 9:19 ` [PATCH 04/10] drm/i915/lvds: Move some connector specific info across from the encoder Chris Wilson
2011-04-22 16:20 ` Jesse Barnes
2011-04-22 9:19 ` [PATCH 05/10] drm/i915: Move the ACPI lid notifier away from LVDS to the generic panel Chris Wilson
2011-04-22 16:21 ` Jesse Barnes
2011-04-22 9:19 ` [PATCH 06/10] drm/i915/dp: Enable lid notifier for eDP Chris Wilson
2011-04-22 9:19 ` [PATCH 07/10] drm/i915: Move the fixed_mode away from drm_i915_private and to the panel Chris Wilson
2011-04-22 16:23 ` Jesse Barnes
2011-04-22 9:19 ` [PATCH 08/10] drm/i915/dp: If the panel has a fixed_mode, it can only be eDP Chris Wilson
2011-04-22 16:24 ` Jesse Barnes
2011-04-22 9:19 ` [PATCH 09/10] drm/i015: Share the EDID caching logic and mode query between LVDS and eDP Chris Wilson
2011-04-22 16:26 ` Jesse Barnes
2011-04-22 9:19 ` [PATCH 10/10] drm/i915: Only force a modeset on a lid event if fbcon is active Chris Wilson
2011-04-22 16:27 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2012-10-19 11:51 [PATCH 00/10] drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring Jani Nikula
2012-10-19 11:51 ` [PATCH 02/10] drm/i915/lvds: Introduce intel_lvds_connector Jani Nikula
2012-10-19 16:47 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$irdv0c@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox