From: "Das, Nirmoy" <nirmoy.das@intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: priyanka.dandamudi@intel.com, intel-gfx@lists.freedesktop.org,
naresh.kamboju@linaro.org, matthew.auld@intel.com
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: disable pci resize on 32-bit machine
Date: Thu, 28 Jul 2022 09:58:55 +0200 [thread overview]
Message-ID: <bae2b00c-276e-a522-ead2-7f9f0fbd249a@intel.com> (raw)
In-Reply-To: <YuGg45GRtl7w1r1I@alfio.lan>
On 7/27/2022 10:32 PM, Andi Shyti wrote:
> Hi Nirmoy,
>
> On Wed, Jul 27, 2022 at 07:33:06PM +0200, Nirmoy Das wrote:
>> PCI bar resize only works with 64 bit BAR so disable
>> this on 32-bit machine and resolve below compilation error:
>>
>> drivers/gpu/drm/i915/gt/intel_region_lmem.c:94:23: error: result of
>> comparison of constant 4294967296 with expression of type
>> 'resource_size_t' (aka 'unsigned int') is always false
>> [-Werror,-Wtautological-constant-out-of-range-compare]
>> root_res->start > 0x100000000ull)
>>
>> Fixes: a91d1a17cd341 ("drm/i915: Add support for LMEM PCIe resizable bar")
>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
>> Acked-by: Matthew Auld <matthew.auld@intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Andi
>
> PS You forgot to CC the author of the patch you are fixing
Yes missed that :/ Thanks for reviewing , Andi.
Nirmoy
next prev parent reply other threads:[~2022-07-28 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 17:33 [Intel-gfx] [PATCH v2] drm/i915: disable pci resize on 32-bit machine Nirmoy Das
2022-07-27 19:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: disable pci resize on 32-bit machine (rev2) Patchwork
2022-07-27 20:32 ` [Intel-gfx] [PATCH v2] drm/i915: disable pci resize on 32-bit machine Andi Shyti
2022-07-28 7:58 ` Das, Nirmoy [this message]
2022-07-28 8:09 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: disable pci resize on 32-bit machine (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bae2b00c-276e-a522-ead2-7f9f0fbd249a@intel.com \
--to=nirmoy.das@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=naresh.kamboju@linaro.org \
--cc=priyanka.dandamudi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox