Re: [Intel-gfx] [PATCH] drm/i915/dg2: Print PHY name properly on calibration error

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 15/02/2022 16:35, Matt Roper wrote:
> We need to use phy_name() to convert the PHY value into a human-readable
> character in the error message.
> 
> Fixes: a6a128116e55 ("drm/i915/dg2: Wait for SNPS PHY calibration during display init")

I picked this for drm-intel-fixes, and as it did not apply cleanly, 
noticed in the process that a6a128116e55 is all the way back in 5.15. I 
reckon you didn't want to copy stable because it is just a log message 
tweak?

Regards,

Tvrtko

> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> index 8573a458811a..8fd00de981fc 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> @@ -35,7 +35,7 @@ void intel_snps_phy_wait_for_calibration(struct drm_i915_private *i915)
>   		if (intel_de_wait_for_clear(i915, ICL_PHY_MISC(phy),
>   					    DG2_PHY_DP_TX_ACK_MASK, 25))
>   			drm_err(&i915->drm, "SNPS PHY %c failed to calibrate after 25ms.\n",
> -				phy);
> +				phy_name(phy));
>   	}
>   }
>