Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [Intel-gfx] [PATCH v4 13/14] drm/i915: axe lots of unnecessary includes from i915_drv.h
Date: Thu, 10 Feb 2022 17:45:51 +0200	[thread overview]
Message-ID: <bc2bbcd46b66e44e98e1ef76980dfabcfac700d5.1644507885.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1644507885.git.jani.nikula@intel.com>

It's fairly difficult to ensure these are actually not needed due to
indirect includes via other files. However, it's easier to add them back
as needed and, most importantly, where needed instead of exhaustively
proving they're unnecessary.

Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 6d28f16f71e6..3bb2c48018a0 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -34,25 +34,12 @@
 
 #include <asm/hypervisor.h>
 
-#include <linux/io-mapping.h>
 #include <linux/i2c.h>
 #include <linux/i2c-algo-bit.h>
-#include <linux/backlight.h>
-#include <linux/hash.h>
 #include <linux/intel-iommu.h>
-#include <linux/kref.h>
-#include <linux/mm_types.h>
-#include <linux/perf_event.h>
 #include <linux/pm_qos.h>
-#include <linux/dma-resv.h>
-#include <linux/stackdepot.h>
 
-#include <drm/drm_gem.h>
-#include <drm/drm_auth.h>
-#include <drm/drm_util.h>
-#include <drm/drm_dsc.h>
 #include <drm/drm_connector.h>
-#include <drm/i915_mei_hdcp_interface.h>
 #include <drm/ttm/ttm_device.h>
 
 #include "i915_params.h"
@@ -89,17 +76,12 @@
 #include "intel_runtime_pm.h"
 #include "intel_step.h"
 #include "intel_uncore.h"
-#include "intel_wakeref.h"
 #include "intel_wopcm.h"
 
 #include "i915_gem.h"
-#include "i915_gem_gtt.h"
 #include "i915_gpu_error.h"
 #include "i915_perf_types.h"
-#include "i915_request.h"
 #include "i915_scheduler.h"
-#include "gt/intel_timeline.h"
-#include "i915_vma.h"
 
 struct dpll;
 struct drm_i915_clock_gating_funcs;
-- 
2.30.2


  parent reply	other threads:[~2022-02-10 15:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 15:45 [Intel-gfx] [PATCH v4 00/14] drm/i915: drm_i915.h cleanup Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 01/14] drm/i915: split out i915_gem_internal.h from i915_drv.h Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 02/14] drm/i915: remove leftover i915_gem_pm.h declarations " Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 03/14] drm/i915: split out gem/i915_gem_dmabuf.h " Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 04/14] drm/i915: split out gem/i915_gem_create.h " Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 05/14] drm/i915: split out gem/i915_gem_domain.h " Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 06/14] drm/i915: move i915_cache_level_str() static in i915_debugfs.c Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 07/14] drm/i915: move i915_gem_vm_lookup() where it's used Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 08/14] drm/i915: move i915_reset_count()/i915_reset_engine_count() out of i915_drv.h Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 09/14] drm/i915: split out i915_file_private.h from i915_drv.h Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 10/14] drm/i915: don't include drm_cache.h in i915_drv.h Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 11/14] drm/i915: include shmem_fs.h only where needed Jani Nikula
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 12/14] drm/i915: include some drm headers " Jani Nikula
2022-02-10 15:45 ` Jani Nikula [this message]
2022-02-10 15:45 ` [Intel-gfx] [PATCH v4 14/14] drm/i915: fix drm_i915.h include grouping and sorting Jani Nikula
2022-02-10 16:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm_i915.h cleanup Patchwork
2022-02-10 16:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-10 17:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-10 17:48 ` [Intel-gfx] [PATCH v4 00/14] " Tvrtko Ursulin
2022-02-14 12:20   ` Jani Nikula
2022-02-10 19:41 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc2bbcd46b66e44e98e1ef76980dfabcfac700d5.1644507885.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox