public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 0/4] drm/i915/ttm: Evict and store of compressed object
Date: Wed, 2 Mar 2022 16:31:49 +0100	[thread overview]
Message-ID: <be7c7a5c-0e0d-6949-a146-dc961ef938c9@linux.intel.com> (raw)
In-Reply-To: <20220301215334.20543-1-ramalingam.c@intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> for the series as well.

On 01/03/2022 22:53, Ramalingam C wrote:
> On Xe-HP and later devices, we use dedicated compression control
> state (CCS) stored in local memory for each surface, to support
> the 3D and media compression formats.
>
> The memory required for the CCS of the entire local memory is
> 1/256 of the local memory size. So before the kernel
> boot, the required memory is reserved for the CCS data and a
> secure register will be programmed with the CCS base address
>
> So when we allocate a object in local memory we dont need to explicitly
> allocate the space for ccs data. But when we evict the obj into the smem
> to hold the compression related data along with the obj we need smem
> space of obj_size + (obj_size/256).
>
> Hence when we create smem for an obj with lmem placement possibility we
> create with the extra space.
>
> When we are swapping out the local memory obj on flat-ccs capable platform,
> we need to capture the ccs data too along with main meory and we need to
> restore it when we are swapping in the content.
>
> When lmem object is swapped into a smem obj, smem obj will
> have the extra pages required to hold the ccs data corresponding to the
> lmem main memory. So main memory of lmem will be copied into the initial
> pages of the smem and then ccs data corresponding to the main memory
> will be copied to the subsequent pages of smem.
>
> Swapin happens exactly in reverse order. First main memory of lmem is
> restored from the smem's initial pages and the ccs data will be restored
> from the subsequent pages of smem.
>
> Extracting and restoring the CCS data is done through a special cmd called
> XY_CTRL_SURF_COPY_BLT
>
> Test-with: 20220301212513.30772-1-ramalingam.c@intel.com
>
> Ayaz A Siddiqui (1):
>    drm/i915/gt: Clear compress metadata for Xe_HP platforms
>
> Ramalingam C (3):
>    drm/ttm: parameter to add extra pages into ttm_tt
>    drm/i915/gem: Extra pages in ttm_tt for ccs data
>    drm/i915/migrate: Evict and restore the flatccs capable lmem obj
>
>   drivers/gpu/drm/drm_gem_vram_helper.c        |   2 +-
>   drivers/gpu/drm/i915/gem/i915_gem_ttm.c      |  23 +-
>   drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  15 +
>   drivers/gpu/drm/i915/gt/intel_migrate.c      | 327 +++++++++++++++++--
>   drivers/gpu/drm/qxl/qxl_ttm.c                |   2 +-
>   drivers/gpu/drm/ttm/ttm_agp_backend.c        |   2 +-
>   drivers/gpu/drm/ttm/ttm_tt.c                 |  12 +-
>   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c   |   2 +-
>   include/drm/ttm/ttm_tt.h                     |   4 +-
>   9 files changed, 357 insertions(+), 32 deletions(-)
>

      parent reply	other threads:[~2022-03-02 15:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 21:53 [Intel-gfx] [PATCH v2 0/4] drm/i915/ttm: Evict and store of compressed object Ramalingam C
2022-03-01 21:53 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/gt: Clear compress metadata for Xe_HP platforms Ramalingam C
2022-03-03  7:39   ` Hellstrom, Thomas
2022-03-01 21:53 ` [Intel-gfx] [PATCH v2 2/4] drm/ttm: parameter to add extra pages into ttm_tt Ramalingam C
2022-03-02 12:54   ` Thomas Hellström
2022-03-02 13:24   ` Christian König
2022-03-01 21:53 ` [Intel-gfx] [PATCH v2 3/4] drm/i915/gem: Extra pages in ttm_tt for ccs data Ramalingam C
2022-03-02 12:58   ` Thomas Hellström
2022-03-01 21:53 ` [Intel-gfx] [PATCH v2 4/4] drm/i915/migrate: Evict and restore the flatccs capable lmem obj Ramalingam C
2022-03-03  8:04   ` Hellstrom, Thomas
2022-03-02  1:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ttm: Evict and store of compressed object (rev2) Patchwork
2022-03-02  1:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-02  2:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-02  8:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-02 15:31 ` Das, Nirmoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be7c7a5c-0e0d-6949-a146-dc961ef938c9@linux.intel.com \
    --to=nirmoy.das@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox