Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Shankar, Uma" <uma.shankar@intel.com>
To: "Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
Date: Mon, 31 Aug 2020 07:59:25 +0000	[thread overview]
Message-ID: <c045a8a3fd024fad94fd41631c34e953@intel.com> (raw)
In-Reply-To: <20200828061941.17051-2-jani.nikula@intel.com>



> -----Original Message-----
> From: Jani Nikula <jani.nikula@intel.com>
> Sent: Friday, August 28, 2020 11:50 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Shankar, Uma
> <uma.shankar@intel.com>
> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if
> available
> 
> If a panel's EDID is broken, there may be an override EDID set in the ACPI
> OpRegion mailbox #5. Use it if available.

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

> Cc: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index c57ac83bf563..d1307be196a2 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct intel_dp
> *intel_dp,
>  		goto out_vdd_off;
>  	}
> 
> +	/* Set up override EDID, if any, from ACPI OpRegion */
> +	intel_opregion_edid_override(intel_connector);
> +
>  	mutex_lock(&dev->mode_config.mutex);
>  	edid = drm_get_edid(connector, &intel_dp->aux.ddc);
>  	if (edid) {
> --
> 2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-08-31  7:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28  6:19 [Intel-gfx] [PATCH 1/2] drm/i915/opregion: add support for mailbox #5 EDID Jani Nikula
2020-08-28  6:19 ` [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available Jani Nikula
2020-08-31  7:59   ` Shankar, Uma [this message]
2020-08-28  6:28 ` [Intel-gfx] [PATCH 1/2] drm/i915/opregion: add support for mailbox #5 EDID Jani Nikula
2020-08-31  7:56   ` Shankar, Uma
2020-08-28  6:45 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] " Patchwork
2020-08-28  7:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-08-31 13:39 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
2020-08-31 18:23   ` Jani Nikula
2020-09-01 13:18     ` Jani Nikula
2020-09-02 10:11       ` Ville Syrjälä
2020-09-02 11:34         ` Jani Nikula
  -- strict thread matches above, loose matches on Subject: below --
2020-10-12  8:37 [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available Lee, Shawn C
2020-10-12  9:09 ` Jani Nikula
2020-10-13  9:56   ` Lee, Shawn C
2020-10-13 11:03     ` Jani Nikula
2020-10-14 14:11       ` Lee, Shawn C
2020-10-14 14:14         ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c045a8a3fd024fad94fd41631c34e953@intel.com \
    --to=uma.shankar@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox