Re: [PATCH 3/3] drm/i915/guc/slpc: Print more SLPC debug status information

["Belgaumkar, Vinay" <vinay.belgaumkar@intel.com>]

On 1/8/2025 6:13 AM, Rodrigo Vivi wrote:
> Let's peak on the Balancer and DCC status, now that we
> are using the default strategies.
s/peak/peek
>
> v2: fix identation
>
> Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> index 722da8a7f852..7a9a79fb46fb 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> @@ -774,6 +774,23 @@ int intel_guc_slpc_print_info(struct intel_guc_slpc *slpc, struct drm_printer *p
>   			drm_printf(p, "\tSLPC state: %s\n", slpc_get_state_string(slpc));
>   			drm_printf(p, "\tGTPERF task active: %s\n",
>   				   str_yes_no(slpc_tasks->status & SLPC_GTPERF_TASK_ENABLED));
> +			drm_printf(p, "\tDCC enabled: %s\n",
> +				   str_yes_no(slpc_tasks->status &
> +					      SLPC_DCC_TASK_ENABLED));
> +			drm_printf(p, "\tDCC in: %s\n",
> +				   str_yes_no(slpc_tasks->status & SLPC_IN_DCC));
> +			drm_printf(p, "\tBalancer enabled: %s\n",
> +				   str_yes_no(slpc_tasks->status &
> +					      SLPC_BALANCER_ENABLED));
> +			drm_printf(p, "\tIBC enabled: %s\n",
> +				   str_yes_no(slpc_tasks->status &
> +					      SLPC_IBC_TASK_ENABLED));
> +			drm_printf(p, "\tBalancer IA LMT enabled: %s\n",
> +				   str_yes_no(slpc_tasks->status &
> +					      SLPC_BALANCER_IA_LMT_ENABLED));
> +			drm_printf(p, "\tBalancer IA LMT active: %s\n",
> +				   str_yes_no(slpc_tasks->status &
> +					      SLPC_BALANCER_IA_LMT_ACTIVE));
Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>   			drm_printf(p, "\tMax freq: %u MHz\n",
>   				   slpc_decode_max_freq(slpc));
>   			drm_printf(p, "\tMin freq: %u MHz\n",