From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Wrap interactive header
Date: Wed, 3 Feb 2021 13:12:05 +0000 [thread overview]
Message-ID: <c3f9a058-307b-3fee-526b-a17a871f8fb3@linux.intel.com> (raw)
In-Reply-To: <161235004418.6538.3517367090743505584@build.alporthouse.com>
On 03/02/2021 11:00, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2021-02-03 10:31:04)
>>
>> On 01/02/2021 12:07, Chris Wilson wrote:
>>> Quoting Tvrtko Ursulin (2021-02-01 11:57:56)
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> Slight improvement with regards to wrapping header components to fit
>>>> console width. If a single element is wider than max it can still
>>>> overflow but it should now work better for practical console widths.
>>>
>>> <----
>>> intel-gpu-top: Intel Kabylake (Gen9) @ /dev/dri/card0
>>> 900/ 949 MHz; 0% RC6; 6.97/18.42 W; 2 irqs/s
>>> IMC reads: 6 MiB/s
>>> IMC writes: 0 MiB/s
>>>
>>> ---->
>>> intel-gpu-top: Intel Kabylake (Gen9) @ /dev/dri/card0 - 903/ 954 MHz; 0% RC6
>>> 7.16/18.40 W; 14 irqs/s
>>>
>>> IMC reads: 80 MiB/s
>>> IMC writes: 0 MiB/s
>>>
>>> I thought it looked reasonably tidy, without adding any lines to the
>>> header.
>>
>> Or on a wider terminal:
>> <----
>> intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0
>> 0/ 0 MHz; 100% RC6; 0.00/ 1.29 W; 0 irqs/s
>> IMC reads: 138 MiB/s
>> IMC writes: 6 MiB/s
>> --->
>> intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0 - 0/ 0 MHz; 100% RC6; 0.00/ 0.00 W; 0 irqs/s
>>
>> IMC reads: 77 MiB/s
>> IMC writes: 4 MiB/s
>>
>>
>> So a "fight" between 80 chars vs 120 (or so). :) It may be a bit of an over-engineered solution but I don't like the wrap on a wide terminal, plus I like an extra blank line.
>
> But the memory counters are visually similar to the
> frequency/rc6/power/interrupts...
But I broke my layout by accident when rebasing client stats... ;D
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-03 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:57 [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Wrap interactive header Tvrtko Ursulin
2021-02-01 12:07 ` Chris Wilson
2021-02-03 10:31 ` Tvrtko Ursulin
2021-02-03 11:00 ` [Intel-gfx] [igt-dev] " Chris Wilson
2021-02-03 13:12 ` Tvrtko Ursulin [this message]
2021-02-03 17:02 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f9a058-307b-3fee-526b-a17a871f8fb3@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox