From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eugeni Dodonov <eugeni@dodonov.net>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: add debugfs interface to control rc6 and rps
Date: Tue, 29 Nov 2011 14:39:14 +0000 [thread overview]
Message-ID: <c55c5d$185809@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <CAC7LmnsZUr-BZQvTestzL50rOta+kGMxTb6ipB0v3tiLdKx=Ug@mail.gmail.com>
On Tue, 29 Nov 2011 12:26:23 -0200, Eugeni Dodonov <eugeni@dodonov.net> wrote:
> For the perf counters, I thought on the following flow of execution with
> this patch:
> 1. prev_val=$(cat /sys/kernel/debug/dri/0/i915_enable_rc6)
> 2. echo 0 > /sys/kernel/debug/dri/0/i915_enable_rc6
> 3. do the perf counters aquisition and testing
> 4. echo $(prev_val) > /sys/kernel/debug/dri/0/i915_enable_rc6
>
> Comments?
debugfs should never be ABI. Development and debug testing is one thing,
but if we are serious about this, we need to start building an acceptable
user interface elsewhere in /sys.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-29 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 12:55 [PATCH 1/2] drm/i915: enable deepest RC6 state Eugeni Dodonov
2011-11-29 12:55 ` [PATCH 2/2] drm/i915: add debugfs interface to control rc6 and rps Eugeni Dodonov
2011-11-29 13:05 ` Chris Wilson
2011-11-29 14:12 ` Daniel Vetter
2011-11-29 14:26 ` Eugeni Dodonov
2011-11-29 14:39 ` Chris Wilson [this message]
2011-11-29 13:01 ` [PATCH 1/2] drm/i915: enable deepest RC6 state Chris Wilson
2011-11-29 21:42 ` Ben Widawsky
2011-11-29 23:46 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c55c5d$185809@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=eugeni@dodonov.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox