Re: [Intel-gfx] [PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

["Christian König" <ckoenig.leichtzumerken@gmail.com>]

Am 16.11.22 um 10:20 schrieb Arunpravin Paneer Selvam:
> Hi Amar,
>
> On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote:
>> ttm_resource allocate size in bytes i.e less than page size.
>>
>> Signed-off-by: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
>> ---
>>   drivers/gpu/drm/drm_gem.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index b8db675e7fb5..a346e3b7f9a8 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -152,7 +152,7 @@ EXPORT_SYMBOL(drm_gem_object_init);
>>   void drm_gem_private_object_init(struct drm_device *dev,
>>                    struct drm_gem_object *obj, size_t size)
>>   {
>> -    BUG_ON((size & (PAGE_SIZE - 1)) != 0);
>> +    //BUG_ON((size & (PAGE_SIZE - 1)) != 0);
> This line is added by mistake?

Yeah, comment it out is not a good idea. Instead we should probably move 
it somewhere else, e.g. the shmem object initializing code path still 
needs this.

Additional to that please re-order the patches, this here is a 
prerequisite and should come first.

Regards,
Christian.

>
> Regards,
> Arun
>>         obj->dev = dev;
>>       obj->filp = NULL;
>