Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Liu Aleaxander <aleaxander@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Add aub debug support for kernel
Date: Sun, 07 Nov 2010 16:03:17 +0000	[thread overview]
Message-ID: <c6d829$pfdhot@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <5b55a1$ijdg71@fmsmga002.fm.intel.com>

Oh my, this turns out to be quite hacky indeed...

if (i915_trace_on_load) {
	const struct ftrace_event_call enable_list[] = {
#define EVENT(name) event_call_##name
		&EVENT(i915_reg),
		NULL,
	}, *call = enable_list;
	do {
		if ((*call)->class->reg(*call, TRACE_REG_REGISTER) == 0)
			(*call)->flags |= TRACE_EVENT_FL_ENABLED;
		else
			DRM_DEBUG("failed to enable tracepoint '%s'\n",
				(*call)->name);
	} while (*++call);
}

[Not even compile tested! ;)]

That would seem to do the trick. The alternative would be to override the
use of trace_event_raw_init in the include/trace/ftrace.h macros. In light
of that the above seems much simpler.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  parent reply	other threads:[~2010-11-07 16:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02  9:11 [PATCH] drm/i915: Add aub debug support for kernel Yuanhan Liu
2010-11-02 10:02 ` Chris Wilson
2010-11-02 14:55   ` Liu Aleaxander
2010-11-04  3:44     ` Liu, Yuanhan
2010-11-04  3:51       ` Liu, Yuanhan
2010-11-04  9:30       ` Chris Wilson
2010-11-05 16:43         ` Liu Aleaxander
2010-11-05 17:11           ` Chris Wilson
2010-11-05 17:39             ` Liu Aleaxander
2010-11-07 14:08             ` Liu Aleaxander
2010-11-07 14:23               ` Chris Wilson
2010-11-07 15:04                 ` Liu Aleaxander
2010-11-07 15:33                   ` Chris Wilson
2010-11-07 15:48                     ` Liu Aleaxander
2010-11-07 16:03                     ` Chris Wilson [this message]
2010-11-08  9:23                       ` Yuanhan Liu
2010-11-08  9:55                         ` Chris Wilson
2010-11-09  1:55                           ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='c6d829$pfdhot@fmsmga001.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=aleaxander@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox