From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jeremy Kerr <jeremy.kerr@canonical.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: dont use i915_driver_unload() to cleanup failed vblank init
Date: Wed, 17 Nov 2010 11:19:13 +0000 [thread overview]
Message-ID: <c6d829$pin5k9@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1289975093.142900.349539985875.1.gpush@pororo>
On Wed, 17 Nov 2010 14:24:53 +0800, Jeremy Kerr <jeremy.kerr@canonical.com> wrote:
> Currently, i915_driver_load calls i915_driver_unload if drm_vblank_init
> fails. However, we have not yet fully initialised drm_i915_private (eg.
> ->hangcheck_timer), so we're calling unload from an inconsistent state.
>
> This change uses the existing error path to do the cleanup instead, as
> is used before and after the drm_vblank_init() call.
Already done for -next, thanks anyway.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-11-17 11:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 6:24 [PATCH] drm/i915: don't use i915_driver_unload() to cleanup failed vblank init Jeremy Kerr
2010-11-17 11:19 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c6d829$pin5k9@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jeremy.kerr@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox