From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, christian.koenig@amd.com
Subject: Re: [Intel-gfx] [PATCH 2/2] dma-buf: fix dma-fence-chain out of order test
Date: Thu, 25 Jun 2020 16:23:25 +0300 [thread overview]
Message-ID: <c6f72d4d-c8a0-c484-7c31-761e9c37b85e@intel.com> (raw)
In-Reply-To: <159309113252.4527.2883585204850736358@build.alporthouse.com>
On 25/06/2020 16:18, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2020-06-25 13:34:43)
>> There was probably a misunderstand on how the dma-fence-chain is
>> supposed to work or what dma_fence_chain_find_seqno() is supposed to
>> return.
>>
>> dma_fence_chain_find_seqno() is here to give us the fence to wait upon
>> for a particular point in the timeline. The timeline progresses only
>> when all the points prior to a given number have completed.
> Hmm, the question was what point is it supposed to wait for.
>
> For the simple chain of [1, 3], does 1 being signaled imply that all
> points up to 3 are signaled, or does 3 not being signaled imply that all
> points after 1 are not. If that's mentioned already somewhere, my bad.
> If not, could you put the answer somewhere.
> -Chris
In [1, 3], if 1 is signaled, the timeline value is 1. And find_seqno(2)
should return NULL.
In the out_of_order selftest the chain was [1, 2, 3], 2 was signaled and
the test was expecting no fence to be returned by find_seqno(2).
But we still have to wait on 1 to complete before find_seqno(2) can
return NULL (as in you don't have to wait on anything).
Hope that answer the question.
-Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-25 13:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 12:34 [Intel-gfx] [PATCH 1/2] Revert "dma-buf: Report signaled links inside dma-fence-chain" Lionel Landwerlin
2020-06-25 12:34 ` [Intel-gfx] [PATCH 2/2] dma-buf: fix dma-fence-chain out of order test Lionel Landwerlin
2020-06-25 12:44 ` Christian König
2020-06-25 13:18 ` Chris Wilson
2020-06-25 13:23 ` Lionel Landwerlin [this message]
2020-06-25 13:47 ` Chris Wilson
2020-06-25 13:56 ` Lionel Landwerlin
2020-06-25 13:59 ` Daniel Vetter
2020-07-02 12:57 ` Christian König
2020-06-25 12:43 ` [Intel-gfx] [PATCH 1/2] Revert "dma-buf: Report signaled links inside dma-fence-chain" Christian König
2020-06-25 17:13 ` Dave Airlie
2020-06-25 19:27 ` Jani Nikula
2020-06-25 19:54 ` Daniel Vetter
2020-06-26 4:43 ` Sumit Semwal
2020-06-26 7:03 ` Christian König
2020-06-26 12:39 ` Daniel Vetter
2020-06-26 15:34 ` Sumit Semwal
2020-06-26 1:36 ` Dave Airlie
2020-07-02 8:26 ` Lionel Landwerlin
2020-07-02 8:28 ` Christian König
2020-06-26 14:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f72d4d-c8a0-c484-7c31-761e9c37b85e@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox