Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Intel-gfx@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] Revert "drm/i915/dmabuf: fix broken build"
Date: Mon, 22 Nov 2021 14:04:45 +0000	[thread overview]
Message-ID: <c95fe70e-1ce0-5f86-4248-39571c2b0782@intel.com> (raw)
In-Reply-To: <20211122135758.85444-1-tvrtko.ursulin@linux.intel.com>

On 22/11/2021 13:57, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> This reverts commit 777226dac058d119286b4081953cb5aa2cb7394b.
> 
> Approach taken in the patch was rejected by Linus and the upstream tree
> now already contains the required include directive via 304ac8032d3f
> ("Merge tag 'drm-next-2021-11-12' of git://anongit.freedesktop.org/drm/drm").
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: 777226dac058 ("drm/i915/dmabuf: fix broken build")
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>

Acked-by: Matthew Auld <matthew.auld@intel.com>

This was copy-paste from gem/i915_gem_pm.c, does that need a similar patch?

> ---
>   drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> index f291cf4c3886..1b526039a60d 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> @@ -17,13 +17,6 @@
>   
>   MODULE_IMPORT_NS(DMA_BUF);
>   
> -#if defined(CONFIG_X86)
> -#include <asm/smp.h>
> -#else
> -#define wbinvd_on_all_cpus() \
> -	pr_warn(DRIVER_NAME ": Missing cache flush in %s\n", __func__)
> -#endif
> -
>   I915_SELFTEST_DECLARE(static bool force_different_devices;)
>   
>   static struct drm_i915_gem_object *dma_buf_to_obj(struct dma_buf *buf)
> 

  reply	other threads:[~2021-11-22 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 13:57 [Intel-gfx] [PATCH] Revert "drm/i915/dmabuf: fix broken build" Tvrtko Ursulin
2021-11-22 14:04 ` Matthew Auld [this message]
2021-11-22 15:31   ` Tvrtko Ursulin
2021-11-22 18:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-11-22 18:42 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-22 19:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-23  0:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c95fe70e-1ce0-5f86-4248-39571c2b0782@intel.com \
    --to=matthew.auld@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox