From: Casey Bowman <casey.g.bowman@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: thomas.hellstrom@linux.intel.com,
intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Require INTEL_GTT to depend on X86
Date: Sat, 19 Mar 2022 10:37:19 -0700 [thread overview]
Message-ID: <cb45e65d-9fe3-0691-7a45-5d2fdcf4d354@intel.com> (raw)
In-Reply-To: <20220319034045.ki34nyoejk5hdg7z@ldmartin-desk2>
On 3/18/22 20:40, Lucas De Marchi wrote:
> On Fri, Mar 18, 2022 at 07:00:41PM -0700, Casey Bowman wrote:
>> The intel-gtt module is not used on other, non-x86 platforms, so we
>> will restrict it to x86 platforms only.
>>
>> Signed-off-by: Casey Bowman <casey.g.bowman@intel.com>
>
> this should probably be the second patch, not the first.
Good point, will rearrange in v2
Regards,
Casey
>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>
> Lucas De Marchi
>
>
>> ---
>> drivers/gpu/drm/i915/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
>> index 63db8bcf03bf..b381e14863a6 100644
>> --- a/drivers/gpu/drm/i915/Kconfig
>> +++ b/drivers/gpu/drm/i915/Kconfig
>> @@ -4,7 +4,7 @@ config DRM_I915
>> depends on DRM
>> depends on X86 && PCI
>> depends on !PREEMPT_RT
>> - select INTEL_GTT
>> + select INTEL_GTT if X86
>> select INTERVAL_TREE
>> # we need shmfs for the swappable backing store, and in particular
>> # the shmem_readpage() which depends upon tmpfs
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2022-03-19 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 2:00 [Intel-gfx] [PATCH 0/2] Splitting intel-gtt calls for non-x86 platforms Casey Bowman
2022-03-19 2:00 ` [Intel-gfx] [PATCH 1/2] drm/i915: Require INTEL_GTT to depend on X86 Casey Bowman
2022-03-19 3:40 ` Lucas De Marchi
2022-03-19 17:37 ` Casey Bowman [this message]
2022-03-19 2:00 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Split intel-gtt functions by arch Casey Bowman
2022-03-19 3:39 ` Lucas De Marchi
2022-03-19 17:46 ` Casey Bowman
2022-03-22 11:31 ` Tvrtko Ursulin
2022-03-19 2:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Splitting intel-gtt calls for non-x86 platforms Patchwork
2022-03-19 2:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-19 3:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-19 4:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb45e65d-9fe3-0691-7a45-5d2fdcf4d354@intel.com \
--to=casey.g.bowman@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox