From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/dp: Fix DSC enable code to use cpu_transcoder instead of encoder->type
Date: Thu, 22 Aug 2019 12:18:56 +0200 [thread overview]
Message-ID: <cbfa7b62-4605-b166-beef-fcf49f8275ac@linux.intel.com> (raw)
In-Reply-To: <20190821215950.24223-1-manasi.d.navare@intel.com>
Op 21-08-2019 om 23:59 schreef Manasi Navare:
> This patch fixes the intel_configure_pps_for_dsc_encoder() function to use
> cpu_transcoder instead of encoder->type to select the correct DSC registers
> that was wrongly used in the original patch for one DSC register isntance.
>
> Fixes: 7182414e2530 ("drm/i915/dp: Configure i915 Picture parameter Set
> registers during DSC enabling")
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index 598ddb60f9fb..d4fb7f16f9f6 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -547,7 +547,7 @@ static void intel_configure_pps_for_dsc_encoder(struct intel_encoder *encoder,
> pps_val |= DSC_PIC_HEIGHT(vdsc_cfg->pic_height) |
> DSC_PIC_WIDTH(vdsc_cfg->pic_width / num_vdsc_instances);
> DRM_INFO("PPS2 = 0x%08x\n", pps_val);
> - if (encoder->type == INTEL_OUTPUT_EDP) {
> + if (cpu_transcoder == TRANSCODER_EDP) {
> I915_WRITE(DSCA_PICTURE_PARAMETER_SET_2, pps_val);
> /*
> * If 2 VDSC instances are needed, configure PPS for second
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
I was already fixing this in the bigjoiner series, where encoder might be null entirely. :)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-22 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 21:59 [PATCH] drm/i915/dp: Fix DSC enable code to use cpu_transcoder instead of encoder->type Manasi Navare
2019-08-22 10:18 ` Maarten Lankhorst [this message]
2019-08-22 15:21 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-22 21:17 ` [PATCH] " Manasi Navare
2019-08-23 7:59 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-08-23 8:28 ` [PATCH] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbfa7b62-4605-b166-beef-fcf49f8275ac@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox